-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add slice for frame. #445
add slice for frame. #445
Conversation
f1f431f
to
9a7d544
Compare
@zyzhu What about this PR? should we merge it or close? |
9a7d544
to
dfb0bb4
Compare
@alexpantyukhin Sorry that I didn't have too much time to spare on Deedle after summer. Frame.slice will be handy, though it is more like I'll merge it and fix the documentation test timeout on Travis later. Thanks! |
@zyzhu You are doing a great job, thank you! :) @alexpantyukhin Would you like to consider being co-maintainer too? Having two active maintainers is great if possible |
@dsyme I don't mind :) It would be great :) |
@alexpantyukhin You are now a co-admin |
@alexpantyukhin You don't yet have permission to publish the nuget packages but @zyzhu can do that, and we can give you permission if needed |
Thanks! I appreciate this. |
@alexpantyukhin That's great! Thanks for all the contributions and more in the future! |
But somehow, I don't see a slice option in C#. Is that only available in F#? |
@liugaocn The F# functions are not all exposed to C# yet. They are written in I will find some time to add them one by one in another pull. By the way, it is very easy to write extension functions. You may send a pull request if you are interested. Thanks in advance. |
Are they available in C# right now? |
Sorry that I just looked into this. As I do not write C# often, I'm not too familiar with Deedle's functions exposed in C#. I noticed that the following C# code is equivalent to calling slicing rows and columns in F# var actual = df.Rows[new int[] { 0, 1, 2, 3, 4 }];
var actual = df.Columns[new string[] { "Open", "High" }]; I've added the above two cases in the C# test project. 71e7594 |
#444