Avoid iterating seq multiple times in Frame.ofRecords #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tpetricek I wonder what's the impact of my converting data to array in Frame.ofRecords. Will it affect project such as BigDeedle? Is there a better way of doing this? I want to find a middle ground to make result deterministic but not penalizing lazy loading too much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to address the issue #364
I simply converted seq into array to avoid Frame.ofRecords iterating seq multiple times. It avoids creating frame unintended by user. I also added a test cases using the sample in issue 364.
@tpetricek Are you ok with this temporary allocation?