Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust target framework and dotnet build #393

Merged
merged 8 commits into from
Jul 26, 2018
Merged

Adjust target framework and dotnet build #393

merged 8 commits into from
Jul 26, 2018

Conversation

zyzhu
Copy link
Contributor

@zyzhu zyzhu commented Jul 25, 2018 •
edited
Loading

Changes following reviews by @kblohm

  1. Modified test target to netcoreapp2.1
  2. Removed netstandard from rprovider.plugin
  3. Set default build to exclude rprovider.plugin
  4. Add both msbuild and dotnet build to travis

@zyzhu zyzhu mentioned this pull request Jul 25, 2018
Merged
@zyzhu
Copy link
Contributor Author

zyzhu commented Jul 26, 2018

@kblohm I'll merge for now. Please review whenever you have a chance.

@zyzhu zyzhu closed this Jul 26, 2018
@zyzhu zyzhu reopened this Jul 26, 2018
@zyzhu zyzhu merged commit 705c24a into fslaborg:master Jul 26, 2018
@zyzhu zyzhu deleted the pull391 branch August 4, 2018 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zyzhu