Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet Package should reference FSharp.Core package #715

Closed
matthid opened this issue Mar 2, 2017 · 2 comments
Closed

NuGet Package should reference FSharp.Core package #715

matthid opened this issue Mar 2, 2017 · 2 comments

Comments

@matthid
Copy link
Contributor

matthid commented Mar 2, 2017

Currently the NuGet Package references
Microsoft.FSharp.Core.netcore (>= 1.0.0-alpha-161205) for netcore, but it should use https://www.nuget.org/packages/FSharp.Core/ to be consistent across the ecosystem...

Repro steps

In FAKE vNext I use a complete paket group to compile the FAKE script. Therefore I get (when FSharp.Compiler.Service is a dependency of the group, in addition to FSharp.Core):

error FS0215: Multiple references to 'FSharp.Core.dll' are not permitted

Provide the steps required to reproduce the problem

  1. Clone my FAKE coreclr branch
  2. ./build.sh
  3. run the use external paket.dependencies integration test by hand

(let me know if someone actually wants to do it and needs help)

Known workarounds

Maybe I should manually blacklist Microsoft.FSharp.Core.netcore in Fake.vnext.

matthid added a commit to matthid/FAKE that referenced this issue Mar 5, 2017
@dsyme
Copy link
Contributor

dsyme commented Mar 8, 2017

@matthid Could you send a PR for this? thanks

@dsyme dsyme added the bug label Mar 8, 2017
@dsyme dsyme changed the title NuGet Package should reference FSharp.Core NuGet Package should reference FSharp.Core package Mar 8, 2017
matthid added a commit to matthid/FSharp.Compiler.Service that referenced this issue Mar 8, 2017
@matthid
Copy link
Contributor Author

matthid commented Mar 8, 2017

@dsyme done

@dsyme dsyme closed this as completed in #720 Mar 8, 2017
matthid added a commit to matthid/FAKE that referenced this issue Apr 26, 2017
dsyme added a commit to dsyme/FSharp.Compiler.Service that referenced this issue Apr 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants