Fix missing currency letter to cause the first number of the transaction to be cut of #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion to be cut of (Currencys always have a letter at the 3rd letter of the currency code (http://www.xe.com/iso4217.php))
fruitl00p
added a commit
that referenced
this pull request
Jul 27, 2015
Fix missing currency letter to cause the first number of the transaction to be cut of
|
thanks |
|
is if possible to get an hoxfix version for that fix? at the moment one of our customers can't process his bank statement files and i would prefer just updating my composer file then having the spk class duplicate in the project. Greeting Sven |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Currencys always have a letter at the 3rd letter of the currency code (http://www.xe.com/iso4217.php))
Bug was caused by my last fix #14 since i didnt pay Attantion that if the currency is missing the first number for the transaction will be cut off.
Since the currency ISO's 3rd character is always an Letter i check for [a-zA-Z] now instad of anything.