Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect sha1: generateSignature inside CompeltePurchaseRequest (missing ShopId) #10

Closed
Renegade2u opened this issue Dec 13, 2017 · 3 comments

Comments

@Renegade2u
Copy link

protected function generateSignature()
{
    return sha1(
        $this->getTransactionReference() . $this->getMerchantId() . $this->getMerchantKey()
    );
}

should become

protected function generateSignature()
{
    return sha1(
        $this->getTransactionReference() . **$this->getShopId()** . $this->getMerchantId() . $this->getMerchantKey()
    );
}
@barryvdh
Copy link
Member

Which version are you using?
This commit should have added it already: 8f7c0b8

@barryvdh
Copy link
Member

Ah sorry, in the Complete one. Yes should probably be added there also, can you submit a PR?

robinvalk added a commit that referenced this issue Jan 3, 2018
Sisow now doesn't return an invalid sha1 warning anymore.
@robinvalk
Copy link
Contributor

Fixed with version v2.0.4, thanks for noticing @Renegade2u!

barryvdh pushed a commit that referenced this issue Mar 28, 2018
Sisow now doesn't return an invalid sha1 warning anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants