Network profile is saved as wrong filename

[Spitz3492]

node-wifi/src/windows-connect.js

Line 34 in eeaef52

'nodeWifiConnect.xml',

node-wifi/src/windows-connect.js

Line 52 in eeaef52

return execCommand('del ".\\nodeWifiConnect.xml"');

The windows connect function saves the new network profile under the filename "nodeWifiConnect.xml" but then immediately after uses the netsh command to add the profile using the filename (wifi ssid + ".xml"). This gives me the error, "stdout: 'The system cannot find the file specified.\r\n\r\n\r\n',". So line 34 should write the filename as (ap.ssid + ".xml") not "nodeWifiConnect.xml". After I made this change to the writeFileAsync and the following execCommand delete on line 46, my program connecting to the network successfully.

[samuelcseto]

Hi, I have already fixed this in #76. The library later tries to delete the file named 'nodeWifiConnect.xml' So I guess the correct file name should be 'nodeWifiConnect.xml' and not the SSID.

[samuelcseto]

The pull request is still open so that's why. S pozdravom, Samuel Csető ut 6. 8. 2019 o 15:29 Salatiel <notifications@github.com> napísal(a):

…

Hello, I believe the problem still persists in the NPM version <https://www.npmjs.com/package/node-wifi>. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#78?email_source=notifications&email_token=AGCDA6XADYLACA2FZUQJUTTQDF4DXA5CNFSM4IJN5DIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3VELPQ#issuecomment-518669758>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGCDA6S2NWYZVJYXUEYK3LLQDF4DXANCNFSM4IJN5DIA> .

[Spitz3492]

Change the filename to "nodeWifiConnect.xml" then as well on line #40 because that is what is causing my issue. Your pull is screwing up the master branch of this npm install.

[Spitz3492]

I checked out your branch and it seems you have already fixed this issue. Please commit that change to master.

[samuelcseto]

I am not the author of this repo so I can't merge into master until the author accepts my pull request #76

[friedrith]

Sorry guys, I was in vacation without internet connection. I will merge this pull request #76 as soon as possible.

[friedrith]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.