Feature/Swift 5.5 Supports #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
LGTM |
wooster
pushed a commit
to modmed/then
that referenced
this pull request
Oct 1, 2021
|
LGTM |
|
Are you planning to merge this soon?? |
|
What is the forecast to merge this? |
|
LGTM |
1 similar comment
|
LGTM |
|
This is now merged and live in https://github.com/freshOS/Then/releases/tag/6.0.0, thank you all for your undefeatable patience 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Swift 5.5, Swift team introduced Swift concurrency feature (https://docs.swift.org/swift-book/LanguageGuide/Concurrency.html), which includes a new keyword
await.This will cause confusion and conflict with freshOS/Then 's global function
await.Users will get compiler errors if they build freshOS/Then with Swift 5.5. Although they still can use
Then.awaitto avoid naming conflict, but it's not very convenient.awaittoawaitPromise.awaitfunction (which will callawaitPromiseactually) with deprecated mark for short term back-port supports.All unit test cases passed on my machine, with Xcode 13 Beta 3.