Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented XCM Payment API and updated metadata #987

Merged
merged 5 commits into from
Feb 24, 2025

Conversation

asiniscalchi
Copy link
Member

@asiniscalchi asiniscalchi commented Feb 24, 2025

PR Type

Enhancement, Tests


Description

  • Added XcmPaymentApi implementation to support XCM payment functionalities.

  • Introduced methods for querying payment assets, weight-to-fee conversion, and delivery fees.

  • Updated metadata to reflect new API and associated types.

  • Adjusted metadata tests to align with the new API changes.


Changes walkthrough 📝

Relevant files
Enhancement
lib.rs
Added `XcmPaymentApi` implementation in runtime                   

runtime/laos/src/lib.rs

  • Added XcmPaymentApi implementation for querying payment-related
    details.
  • Introduced methods for acceptable payment assets, weight-to-fee
    conversion, and delivery fees.
  • Imported necessary modules and updated runtime API implementation.
  • +31/-2   
    Tests
    metadata15.golden
    Updated metadata and tests for `XcmPaymentApi`                     

    runtime/laos/src/tests/metadata15.golden

  • Updated metadata to include XcmPaymentApi and its methods.
  • Added new types and adjusted existing type IDs for compatibility.
  • Modified test outputs to align with the new API and metadata changes.
  • +364/-36

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @asiniscalchi asiniscalchi changed the title added first implemnetation payment runtime api added payment runtime api Feb 24, 2025
    @asiniscalchi
    Copy link
    Member Author

    /describe

    @github-actions github-actions bot changed the title added payment runtime api Implemented XCM Payment API and updated metadata Feb 24, 2025
    Copy link

    PR Description updated to latest commit (ffe2bcc)

    @asiniscalchi asiniscalchi marked this pull request as ready for review February 24, 2025 10:04
    luispdm
    luispdm previously approved these changes Feb 24, 2025
    @asiniscalchi asiniscalchi merged commit 266e645 into main Feb 24, 2025
    11 checks passed
    @asiniscalchi asiniscalchi deleted the feature/add_xcm_payment_runtime_api branch February 24, 2025 15:55
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants