Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace NativeElseWasmExecutor with ParachainExecutor and update dependencies #918

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Replace NativeElseWasmExecutor with ParachainExecutor and update dependencies #918

merged 2 commits into from
Dec 16, 2024

Conversation

asiniscalchi
Copy link
Member

@asiniscalchi asiniscalchi commented Dec 16, 2024 •
edited by github-actions bot
Loading

PR Type

Enhancement

Description

  • Replaced NativeElseWasmExecutor with ParachainExecutor across the codebase, modernizing the executor usage.
  • Removed the deprecated ParachainNativeExecutor and its associated implementation.
  • Updated executor initialization to use WasmExecutor with conditional HostFunctions for runtime benchmarking.
  • Added new dependencies frame-benchmarking and sp-io to support benchmarking and runtime features.

Changes walkthrough 📝

Relevant files
Enhancement
eth.rs
Replace NativeElseWasmExecutor with ParachainExecutor in Ethereum
compatibility module

node/src/eth.rs

  • Replaced NativeElseWasmExecutor with ParachainExecutor.
  • Updated function signatures to use ParachainExecutor.
  • Removed deprecated NativeElseWasmExecutor usage.
    		•  +6/-14   
    service.rs
    Modernize executor usage and remove deprecated ParachainNativeExecutor

    node/src/service.rs

  • Replaced NativeElseWasmExecutor with WasmExecutor using HostFunctions.
  • Removed ParachainNativeExecutor and its implementation.
  • Updated executor initialization to use ParachainExecutor.
  • Added conditional HostFunctions for runtime benchmarking.
    		•  +13/-25 
    Dependencies
    Cargo.toml
    Update dependencies for benchmarking and runtime support 

    node/Cargo.toml

  • Added frame-benchmarking and sp-io dependencies.
  • Updated runtime-benchmarks feature list to include frame-benchmarking.

    		•  +3/-0     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @asiniscalchi asiniscalchi marked this pull request as ready for review December 16, 2024 13:25
    @asiniscalchi
    Copy link
    Member Author

    /describe

    @github-actions GitHub Actions
    Copy link

    PR Description updated to latest commit (732a629)

    @github-actions github-actions bot changed the title replace NativeElseWasmExecutor for WasmExecutor Replace NativeElseWasmExecutor with ParachainExecutor and modernize executor usage Dec 16, 2024
    @luispdm
    Copy link
    Contributor

    luispdm commented Dec 16, 2024

    /describe

    @github-actions github-actions bot changed the title Replace NativeElseWasmExecutor with ParachainExecutor and modernize executor usage Replace NativeElseWasmExecutor with ParachainExecutor and update dependencies Dec 16, 2024
    @github-actions GitHub Actions
    Copy link

    PR Description updated to latest commit (4c7746b)

    @luispdm
    Copy link
    Contributor

    luispdm commented Dec 16, 2024

    Following this issue paritytech/polkadot-sdk#5008, we've decided to replace NativeElseWasmExecutor with WasmExecutor, using the templates provided by Frontier and OpenZeppelin:

    asiniscalchi
    asiniscalchi commented Dec 16, 2024
    View reviewed changes
    Copy link
    Member Author

    @asiniscalchi asiniscalchi left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    approved

    @luispdm luispdm mentioned this pull request Dec 16, 2024
    Closed
    @magecnion magecnion merged commit 95fd31a into main Dec 16, 2024
    10 checks passed
    @magecnion magecnion deleted the fix/wasm-executor branch December 16, 2024 14:22
    @luispdm luispdm linked an issue Dec 17, 2024 that may be closed by this pull request
    Fix Venus block production #921
    Open
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @magecnion magecnion magecnion approved these changes

    @tsenovilla tsenovilla tsenovilla approved these changes

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Fix Venus block production
    4 participants
    @asiniscalchi @luispdm @magecnion @tsenovilla