Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Laos Sigma Try Runtime job to use secure WebSocket endpoint #904

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Update Laos Sigma Try Runtime job to use secure WebSocket endpoint #904

merged 1 commit into from
Dec 5, 2024

Conversation

asiniscalchi
Copy link
Member

@asiniscalchi asiniscalchi commented Dec 4, 2024 •
edited by github-actions bot
Loading

PR Type

configuration changes

Description

  • Updated the Laos Sigma Try Runtime job in the GitHub Actions workflow to use a secure WebSocket endpoint (wss://rpc.laossigma.laosfoundation.io) instead of an IP-based WebSocket endpoint.
  • This change improves security and aligns with best practices for endpoint usage.

Changes walkthrough 📝

Relevant files
Configuration changes
build.yml
Update Laos Sigma Try Runtime URI to secure WebSocket endpoint

.github/workflows/build.yml

  • Updated the URI for the Laos Sigma Try Runtime job to use a secure
    WebSocket endpoint (wss://rpc.laossigma.laosfoundation.io) instead of
    an IP-based WebSocket endpoint.
    		•  +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @asiniscalchi
    Copy link
    Member Author

    /describe

    @github-actions github-actions bot changed the title using public node Update Laos Sigma Try Runtime job to use secure WebSocket endpoint Dec 4, 2024
    @github-actions GitHub Actions
    Copy link

    github-actions bot commented Dec 4, 2024

    PR Description updated to latest commit (b77d87e)

    @asiniscalchi asiniscalchi merged commit 18cfa83 into main Dec 5, 2024
    10 checks passed
    @asiniscalchi asiniscalchi deleted the feature/using_public_node_e2e branch December 5, 2024 08:24
    asiniscalchi added a commit that referenced this pull request Dec 11, 2024
    @tsenovilla @asiniscalchi
    Hotfix: Apply pallet treasury migration (#905)
    2dc81bb 
    * using public node (#904)

* Add pallet treasury with its migration and test

* Update golden

* Solve clippy issues

* fmt

* Change hardcoded weight

* fmt

---------

Co-authored-by: Alessandro Siniscalchi <asiniscalchi@gmail.com>
    @tsenovilla tsenovilla mentioned this pull request Dec 12, 2024
    Merged
    asiniscalchi added a commit that referenced this pull request Dec 12, 2024
    @tsenovilla @asiniscalchi
    Hotfix: Apply pallet treasury migration (#905) (#913)
    7e8f86b 
    * using public node (#904)

* Add pallet treasury with its migration and test

* Update golden

* Solve clippy issues

* fmt

* Change hardcoded weight

* fmt

---------

Co-authored-by: Alessandro Siniscalchi <asiniscalchi@gmail.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @magecnion magecnion magecnion approved these changes

    @luispdm luispdm luispdm approved these changes

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @asiniscalchi @magecnion @luispdm