Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and Remove Warnings in async_backing.rs #879

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

asiniscalchi
Copy link
Member

@asiniscalchi asiniscalchi commented Nov 15, 2024

PR Type

enhancement, bug fix


Description

  • Removed unused import AccountId to clean up the code.
  • Added conditional imports for Encode and Decode under the try-runtime feature to ensure they are only included when necessary.
  • Replaced vec![] with sp_std::vec![] to maintain consistency in vector initialization.
  • Fixed a missing import for AccountId in the post_upgrade function to prevent potential runtime errors.

Changes walkthrough 📝

Relevant files
Enhancement
async_backing.rs
Refactor imports and fix warnings in async_backing.rs       

runtime/laos/src/migrations/async_backing.rs

  • Removed unused import AccountId.
  • Added conditional import of Encode and Decode for try-runtime feature.
  • Replaced vec![] with sp_std::vec![] for consistency.
  • Added missing import for AccountId in post_upgrade function.
  • +10/-4   

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @asiniscalchi
    Copy link
    Member Author

    /describe

    @github-actions github-actions bot changed the title remove warning Refactor and Remove Warnings in async_backing.rs Nov 15, 2024
    Copy link

    PR Description updated to latest commit (757d090)

    magecnion
    magecnion previously approved these changes Nov 15, 2024
    @asiniscalchi asiniscalchi merged commit 107fd28 into main Nov 18, 2024
    8 checks passed
    @asiniscalchi asiniscalchi deleted the feature/remove_warning branch November 18, 2024 11:27
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants