-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance and Refactor Vesting Tests with Utility Functions and Configuration Updates #865
Conversation
/describe |
PR Description updated to latest commit (19dac8d) |
/review |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! I added some minor change requests
Co-authored-by: Tomás Senovilla Polo <117524919+tsenovilla@users.noreply.github.com>
Co-authored-by: Tomás Senovilla Polo <117524919+tsenovilla@users.noreply.github.com>
Co-authored-by: Tomás Senovilla Polo <117524919+tsenovilla@users.noreply.github.com>
Co-authored-by: Tomás Senovilla Polo <117524919+tsenovilla@users.noreply.github.com>
Co-authored-by: Tomás Senovilla Polo <117524919+tsenovilla@users.noreply.github.com>
Co-authored-by: Tomás Senovilla Polo <117524919+tsenovilla@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
PR Type
Tests, Enhancement
Description
chai-as-promised
for better promise-based assertions in tests.WsProvider
for WebSocket connections.LOCAL_NODE_URL
toLOCAL_NODE_IP
.web3
dependency version to^1.10.0
in bothpackage.json
andpackage-lock.json
.Changes walkthrough 📝
laos.rs
Remove vesting configuration from test genesis config
node/src/chain_spec/laos.rs
config.ts
Update local node configuration variable name
e2e-tests/tests/config.ts
LOCAL_NODE_URL
toLOCAL_NODE_IP
.test-vesting.ts
Enhance and refactor vesting tests with detailed steps
e2e-tests/tests/test-vesting.ts
chai-as-promised
for promise-based assertions.util.ts
Add utility functions and update provider setup
e2e-tests/tests/util.ts
WsProvider
.package-lock.json
Update web3 dependency version in package-lock
e2e-tests/package-lock.json
web3
dependency version to^1.10.0
.package.json
Update web3 dependency version in package.json
e2e-tests/package.json
web3
dependency version to^1.10.0
.