Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Treasury Payout Period to 28 Days #852

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Update Treasury Payout Period to 28 Days #852

merged 2 commits into from
Oct 24, 2024

Conversation

asiniscalchi
Copy link
Member

@asiniscalchi asiniscalchi commented Oct 24, 2024 •
edited by github-actions bot
Loading

PR Type

enhancement

Description

  • Updated the treasury payout period configuration from 5 days to 28 days.
  • The change involves modifying the PayoutPeriod parameter to be calculated as 28 * DAYS.

Changes walkthrough 📝

Relevant files
Enhancement
treasury.rs
Update treasury payout period to 28 days                                 

runtime/laos/src/configs/treasury.rs

  • Updated the PayoutPeriod from 5 to 28 days.
  • Modified the PayoutPeriod to be calculated as 28 * DAYS.
    		•  +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @asiniscalchi asiniscalchi marked this pull request as ready for review October 24, 2024 10:18
    @asiniscalchi
    Copy link
    Member Author

    /describe

    @asiniscalchi asiniscalchi linked an issue Oct 24, 2024 that may be closed by this pull request
    Address Treasury PayoutPeriod #842
    Closed
    @asiniscalchi
    Copy link
    Member Author

    type PayoutPeriod: Get<BlockNumberFor>
    The period during which an approved treasury spend has to be claimed.

    @github-actions github-actions bot changed the title treasury payout period to 28 days Update Treasury Payout Period to 28 Days Oct 24, 2024
    @github-actions GitHub Actions
    Copy link

    PR Description updated to latest commit (c18c549)

    tsenovilla
    tsenovilla previously approved these changes Oct 24, 2024
    View reviewed changes
    @asiniscalchi asiniscalchi merged commit 316eab7 into main Oct 24, 2024
    7 checks passed
    @asiniscalchi asiniscalchi deleted the feature/payoutPeriod_to_28_days branch October 24, 2024 13:26
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @tsenovilla tsenovilla tsenovilla left review comments

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Address Treasury PayoutPeriod
    2 participants
    @asiniscalchi @tsenovilla