Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove paseo feature and update configurations #849

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Remove paseo feature and update configurations #849

merged 1 commit into from
Oct 24, 2024

Conversation

asiniscalchi
Copy link
Member

@asiniscalchi asiniscalchi commented Oct 24, 2024 •
edited by github-actions bot
Loading

PR Type

enhancement, configuration changes

Description

  • Removed the paseo feature and its related configurations from the codebase.
  • Updated Cargo.toml to exclude the paseo feature.

Changes walkthrough 📝

Relevant files
Configuration changes
xcm_config.rs
Remove paseo feature and related configurations                   

runtime/laos/src/configs/xcm_config.rs

  • Removed conditional compilation for the paseo feature.
  • Deleted the paseo specific RELAY_NETWORK configuration.
    		•  +0/-4     
    Cargo.toml
    Remove paseo feature from Cargo.toml                                         

    runtime/laos/Cargo.toml

    • Removed the paseo feature from the feature list.
    		 +0/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @asiniscalchi
    Copy link
    Member Author

    /describe

    @asiniscalchi asiniscalchi marked this pull request as ready for review October 24, 2024 09:32
    @asiniscalchi asiniscalchi linked an issue Oct 24, 2024 that may be closed by this pull request
    Update RELAY_NETWORK for Polkadot #843
    Closed
    @github-actions github-actions bot changed the title feature paseo removed Remove paseo feature and update configurations Oct 24, 2024
    @github-actions GitHub Actions
    Copy link

    PR Description updated to latest commit (086e776)

    tsenovilla
    tsenovilla approved these changes Oct 24, 2024
    View reviewed changes
    Copy link
    Collaborator

    @tsenovilla tsenovilla left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    lgtm

    @asiniscalchi asiniscalchi merged commit d279029 into main Oct 24, 2024
    9 checks passed
    @asiniscalchi asiniscalchi deleted the feature/remove_paseo_feature branch October 24, 2024 09:47
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @luispdm luispdm luispdm approved these changes

    @tsenovilla tsenovilla tsenovilla approved these changes

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Update RELAY_NETWORK for Polkadot
    3 participants
    @asiniscalchi @luispdm @tsenovilla