Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "staging-" prefix from XCM and parachain info modules and dependencies #803

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

asiniscalchi
Copy link
Member

@asiniscalchi asiniscalchi commented Oct 3, 2024

PR Type

enhancement


Description

  • Updated various Rust modules to replace staging_xcm and related modules with xcm and its corresponding modules.
  • Changed parachain_info configurations to remove the "staging-" prefix.
  • Updated Cargo.toml files to reflect changes in dependencies, removing the "staging-" prefix from XCM and parachain info packages.

Changes walkthrough 📝

Relevant files
Enhancement
mod.rs
Update XCM version reference in chain spec                             

node/src/chain_spec/mod.rs

  • Updated SAFE_XCM_VERSION to use xcm::prelude::XCM_VERSION instead of
    staging_xcm::prelude::XCM_VERSION.
  • +1/-1     
    mod.rs
    Update parachain info configuration                                           

    runtime/laos/src/configs/mod.rs

    • Changed implementation of parachain_info::Config for Runtime.
    +1/-1     
    xcm_config.rs
    Replace staging XCM with XCM in configuration                       

    runtime/laos/src/configs/xcm_config.rs

  • Replaced staging_xcm and staging_xcm_builder with xcm and xcm_builder.
  • Updated XcmExecutor implementation to use xcm_executor.
  • +5/-5     
    xcm_message_queue.rs
    Update XCM message queue configuration                                     

    runtime/laos/src/configs/xcm_message_queue.rs

  • Updated MessageProcessor to use xcm_builder::ProcessXcmMessage.
  • Changed XcmExecutor to use xcm_executor.
  • +2/-2     
    lib.rs
    Update parachain info in runtime construction                       

    runtime/laos/src/lib.rs

  • Updated ParachainInfo to use parachain_info instead of
    staging_parachain_info.
  • +1/-1     
    Dependencies
    Cargo.toml
    Update Cargo dependencies for XCM and parachain info         

    Cargo.toml

  • Replaced staging-parachain-info with parachain-info.
  • Updated XCM related dependencies to remove "staging-" prefix.
  • +4/-4     
    Cargo.toml
    Update XCM dependency in node Cargo                                           

    node/Cargo.toml

    • Changed staging-xcm to xcm.
    +1/-1     
    Cargo.toml
    Update runtime dependencies for XCM and parachain info     

    runtime/laos/Cargo.toml

  • Updated XCM and parachain info dependencies to remove "staging-"
    prefix.
  • +11/-11 

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @asiniscalchi
    Copy link
    Member Author

    /describe

    @github-actions github-actions bot changed the title remove staging- Remove "staging-" prefix from XCM and parachain info modules and dependencies Oct 3, 2024
    Copy link

    github-actions bot commented Oct 3, 2024

    PR Description updated to latest commit (3546c83)

    Copy link
    Collaborator

    @tsenovilla tsenovilla left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    lgtm!

    @asiniscalchi asiniscalchi merged commit cc2054c into main Oct 3, 2024
    9 checks passed
    @asiniscalchi asiniscalchi deleted the feature/remove_staging_ branch October 3, 2024 13:58
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    XCM allows for Sending and Receiving MERC Tokens to/from AssetHub in Zombienet
    3 participants