-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate XCM Simulator with LAOS Runtime and Add Comprehensive Tests #800
Conversation
/describe |
PR Description updated to latest commit (0783497) |
/describe |
PR Description updated to latest commit (2119906) |
/// | ||
/// Asserts that the parachain accounts are updated as expected. | ||
#[test] | ||
fn withdraw_and_deposit_nft() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we finally need to write test related to nfts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope. They are the tests related to the Para* from the polkadot.sdk. Our test will be included in laosish_xcm.rs
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, so maybe we may delete them at some point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we modify the configuration of the mock parachains and they begin to fail, we simply remove them. They're not really within our scope or serving our purpose, but since they're harmless tests, there's no strong reason to remove them. They might still reveal some changes in behavior.
Co-authored-by: Tomás Senovilla Polo <117524919+tsenovilla@users.noreply.github.com>
Co-authored-by: Tomás Senovilla Polo <117524919+tsenovilla@users.noreply.github.com>
Co-authored-by: Tomás Senovilla Polo <117524919+tsenovilla@users.noreply.github.com>
Co-authored-by: Tomás Senovilla Polo <117524919+tsenovilla@users.noreply.github.com>
PR Type
Enhancement, Tests
Description
Changes walkthrough 📝
8 files
balances.rs
Add balance configuration for LAOS runtime
xcm-simulator/src/laosish/configs/balances.rs
ExistentialDeposit
.pallet_balances::Config
forRuntime
.mod.rs
Add module imports and parachain info config
xcm-simulator/src/laosish/configs/mod.rs
parachain_info::Config
forRuntime
.system.rs
Add system configuration for LAOS runtime
xcm-simulator/src/laosish/configs/system.rs
frame_system::Config
forRuntime
.xcm_config.rs
Add XCM configuration for LAOS runtime
xcm-simulator/src/laosish/configs/xcm_config.rs
xcm_executor::Config
forXcmConfig
.mod.rs
Add parachain runtime mock for LAOS
xcm-simulator/src/laosish/mod.rs
lib.rs
Add XCM simulator library setup
xcm-simulator/src/lib.rs
parachain.rs
Add parachain runtime mock configuration
xcm-simulator/src/parachain.rs
relay_chain.rs
Add relay chain runtime mock configuration
xcm-simulator/src/relay_chain.rs
2 files
laosish_xcm.rs
Add tests for LAOS XCM functionality
xcm-simulator/src/tests/laosish_xcm.rs
mod.rs
Add comprehensive XCM operation tests
xcm-simulator/src/tests/mod.rs
4 files
Cargo.toml
Update Cargo.toml for XCM simulator integration
Cargo.toml
xcm-simulator
to workspace members.Cargo.toml
Update primitives for parachains support
primitives/Cargo.toml
parachains-common/std
to std feature.Cargo.toml
Clean up runtime dependencies
runtime/laos/Cargo.toml
Cargo.toml
Add Cargo.toml for XCM simulator
xcm-simulator/Cargo.toml