Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better comments for CheckInherits struct deprecation #603

Merged
merged 6 commits into from
May 28, 2024
Merged

better comments for CheckInherits struct deprecation #603

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7d61bd2
remove allow dead code
asiniscalchi May 24, 2024
ab05a27
added comment
asiniscalchi May 28, 2024
c6f0e88
fix clippy
asiniscalchi May 28, 2024
1e89276
better comments
asiniscalchi May 28, 2024
8a29d76
better comments
asiniscalchi May 28, 2024
438bcf4
fmt
asiniscalchi May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion runtime/laos/src/configs/cumulus_parachain_system.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,10 @@ impl cumulus_pallet_parachain_system::Config for Runtime {
type CheckAssociatedRelayNumber = cumulus_pallet_parachain_system::RelayNumberStrictlyIncreases;
}

#[allow(dead_code)] // TODO: https://github.com/moonbeam-foundation/moonbeam/blob/26a88a553563647992f39fbd1cce3d45a363e991/runtime/moonbeam/src/lib.rs#L1585-L1614
// This struct is never instantiated, it is only used for the `CheckInherents` implementation.
// It will be deprecated soon:
// https://github.com/moonbeam-foundation/moonbeam/blob/26a88a553563647992f39fbd1cce3d45a363e991/runtime/moonbeam/src/lib.rs#L1585-L1614
#[allow(dead_code)]
struct CheckInherents;

impl cumulus_pallet_parachain_system::CheckInherents<Block> for CheckInherents {
Expand Down
Loading