fix: websocket server always should be bound to localhost #1463
+0
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
crates/core
andscripts
directories, focusing on improving configuration handling, test stability, and script usability. The most important changes include modifying the WebSocket API configuration to always use the local address, increasing the sleep duration in tests to ensure node stability, and adding a help function to theupdate-remote-gws.sh
script.Configuration handling improvements:
crates/core/src/config.rs
: Modified the WebSocket API configuration to always use the local address by default.Test stability improvements:
crates/core/tests/operations.rs
: Increased the sleep duration before connecting to the WebSocket API intest_put_contract
andtest_update_contract
to ensure nodes have enough time to start up. [1] [2]Script usability improvements:
scripts/update-remote-gws.sh
: Added a help function to provide usage information and describe expected artifacts and target servers.