Remove unneeded Result during AuthenticationTest post-process #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This Result is incorrectly returned, since it's purpose is to detect when total_threads == 0, but that would cause a ZeroDivisionError that is already handled by the generic exception catching in 7b9d3e7. Because of this, the Result is only returned when in reality there are no errors. Signed-off-by: Antonio Torres <antorres@redhat.com>
|
Looks good, ack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Result is incorrectly returned, since it's purpose is to detect
when total_threads == 0, but that would cause a ZeroDivisionError that
is already handled by the generic exception catching in
7b9d3e7. Because of this, the Result is
only returned when in reality there are no errors.
Signed-off-by: Antonio Torres antorres@redhat.com