Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated default and Xenial-specific testinfra docs #3835

Merged

Conversation

zenmonkeykstop
Copy link
Contributor

Status

Ready for review

Description of Changes

Fixes #3780 and updates documentation related to PR #3833
Docs-only change, updating testinfra instructions.

Testing

Review documentation for accuracy, in particular the section describing how the testinfra tests arelaid out and where new variables and tests should go.

Checklist

If you made changes to documentation:

  • Doc linting (make docs-lint) passed locally

@zenmonkeykstop zenmonkeykstop force-pushed the 3780-docs-update-testinfra branch from 599d401 to e313cda Compare October 1, 2018 22:33
Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few clarifications throughout. Would prefer to get #3833 in so we can rebase this PR and review these changes with the context of the latest Xenial logic.

@conorsch conorsch merged commit 7899089 into freedomofpress:develop Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants