Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed xvfb, tor browser, and firefox installs from app-staging #3695

Conversation

zenmonkeykstop
Copy link
Contributor

Status

Ready for review /

Description of Changes

Fixes #3678
Updates ansible app-test role to remove xvfb, firefox and tor browser installs. These should no longer be required, as they were used for functional tests which are now run remotely.

Testing

From root of securedrop repo, bring up staging Vagrant boxes:

make build-debs
vagrant up /staging/

Vagrant provisioning should complete successfully.

On app-staging, set up test data:

vagrant ssh app-staging
sudo -u www-data bash
cd /var/www/securedrop
./manage.py reset
./create-dev-data.py --staging

Verify that xvfb, firefox, tor browser not installed on app-staging.

Logout from app-staging. On dev workstation, create and edit securedrop/tests/functional/instance_information.json to include staging-specific info, then run functional tests:

cd securedrop
./bin/dev-shell ./bin/run-test -v tests/functional

Tests should run. Note that some tests may fail in staging for reasons unrelated to this PR (tests involving gpg decryption and app session expiry, for example).

Deployment

Checklist

If you made changes to the system configuration:

@zenmonkeykstop
Copy link
Contributor Author

Functional test user setup for local run needs updating - on it.

@zenmonkeykstop
Copy link
Contributor Author

Closing this as tests are b0rked and there's another fix in it that should probably go in independently. Will reissue as two separate PRs.

@zenmonkeykstop zenmonkeykstop deleted the 3678-remove-apptest-browser-installs branch August 4, 2018 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant