Removed xvfb, tor browser, and firefox installs from app-staging #3695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review /
Description of Changes
Fixes #3678
Updates ansible app-test role to remove xvfb, firefox and tor browser installs. These should no longer be required, as they were used for functional tests which are now run remotely.
Testing
From root of securedrop repo, bring up staging Vagrant boxes:
Vagrant provisioning should complete successfully.
On app-staging, set up test data:
Verify that xvfb, firefox, tor browser not installed on app-staging.
Logout from app-staging. On dev workstation, create and edit securedrop/tests/functional/instance_information.json to include staging-specific info, then run functional tests:
Tests should run. Note that some tests may fail in staging for reasons unrelated to this PR (tests involving gpg decryption and app session expiry, for example).
Deployment
Checklist
If you made changes to the system configuration:
(tests currently not working locally, so can't check.)