Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Alt Tag on Newsroom Logo #4280

Open
ninavizz opened this issue Mar 20, 2019 · 9 comments
Open

Update Alt Tag on Newsroom Logo #4280

ninavizz opened this issue Mar 20, 2019 · 9 comments
Labels
blocked help wanted Issues we would definitely appreciate volunteer help with

Comments

@ninavizz
Copy link
Member

ninavizz commented Mar 20, 2019

Description

Sought Immediate Action: Pls update <alt> tag on Newsroom Logo in Source UI to read Logo Image and not SecureDrop

Currently there is no mention of the name of a newsroom on an instance of SecureDrop. This presents two core problems for Sources, in the Source Experience.

  1. The <alt> on the newsroom logo today, is currently SecureDrop. That's strange and misleading. See 0:20 and 0:30 in this video screencast of AlJazeera's SecureDrop loading w/in Tor. A minimum/asap fix, would be updating the static <alt> w/in the code to read Newsroom Logo (sidenote: alt tags are a big accessibility thing, on an aside from also informing users what's what as assets load).

  2. Longer term, the Admin interface should be updated to accept the newsroom's name (including the word The for orgs such as The Intercept or The New York Times) and that alt-tag should be dynamically generated to read <%NewsOrgName%> Logo

User Research Evidence

  • None (yet).
  • General Cognitive Walkthrough Observations from @ninavizz
    • Accessibility audit likely to make <alt> recommendations
    • As a stranger to the Source experience, it looks weird seeing "SecureDrop" as an alt-tag show-up on my screen, to then be replaced by a newsroom's logo.
    • This is a great low-hanging fruit opportunity to start managing user expectations better wrt who they're submitting things to.
    • Get the change into the Admin interface to accept news org names and the dynamic alt-tag in the Source interface, now; then in a tbd release start inserting the news or name in the Source experience after users have validated where it's most useful for them to see.

User Stories

As a Source I want to be less confused about who I'm submitting my stuff to, and what this SecureDrop thing is.

@ninavizz ninavizz changed the title Include Newsroom Name & Update Alt Tag Update Alt Tag on Newsroom Logo Apr 11, 2019
@ninavizz
Copy link
Member Author

ninavizz commented Apr 11, 2019

Hmmm, seems we just got report submitted from Accessibility lab thaaaat seems to validate this? Could the simple update to the alt tag pls to get included in the 0.13 release? 😃 @eloquence

Dynamic inclusion of the newsroom's name can be addressed in a subsequent ticket. Once we have the newsroom's name added to the admin interface, of course. And unicorns deliver burritos to my house from Mars.

@ninavizz
Copy link
Member Author

ninavizz commented May 9, 2019

Bumpitty bump! Could this get a "Help Wanted" tag, and perhaps moved to "Near Term Backlog" per this AM's UX meeting? /cc @eloquence

@eloquence
Copy link
Member

Happy to do so. Given latency in Tor, this ALT text does stick around for a while, and I agree there's some potential for confusion depending on what logo is actually set.

How would you feel about "Logo Image" instead of just "Logo", at least until we qualify it with the newsroom name? The text "Logo" hovering for a few seconds I think has its own potential to look a bit confusing.

@eloquence eloquence added the help wanted Issues we would definitely appreciate volunteer help with label May 9, 2019
@ninavizz
Copy link
Member Author

ninavizz commented May 9, 2019

Updated instructions in OG comment, accordingly—thx for the sound suggestion, Erik!

@drewmassey
Copy link
Contributor

Picking this up this week at @ninavizz 's reccomendation

@drewmassey
Copy link
Contributor

Per convo in PR #4494 I am tabling this until I look at #4480.

@DrGFreeman
Copy link
Contributor

I'm picking this one up as suggested by @zenmonkeykstop on Gitter.

I'll submit a PR shortly that just changes the static <alt> tag from SecureDrop to Logo Image (the short term fix as described above). Then I can look into a longer term solution that dynamically generate the tag using the news organization name.

@ninavizz
Copy link
Member Author

ninavizz commented Nov 9, 2019

@DrGFreeman There is not currently a value in the Admin UI for an org to set their name; that would have to be added, for an alt tag to dynamically generate. At some point in the next year, I'd like to see that value added into the Admin UI and into the data tables... but for now, it's not a high enough priority to merit the testing that'd be required to make it possible. Unless someone else on the team disagrees. THANK YOU for the small change to Logo Image however, that's a big usability help—and something I'd thought had already been taken care of. :)

DrGFreeman added a commit to DrGFreeman/securedrop that referenced this issue Nov 9, 2019
zenmonkeykstop added a commit that referenced this issue Nov 11, 2019
…-static

Changed newsroom logo alt tag to 'Logo Image' (#4280)
@emkll emkll mentioned this issue Nov 28, 2019
24 tasks
@eloquence
Copy link
Member

The first part of this issue was completed in #4980. As mentioned above, further work on this is is blocked until we add support for setting the organizational name in the Admin Interface (#1575).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked help wanted Issues we would definitely appreciate volunteer help with
Projects
None yet
Development

No branches or pull requests

4 participants