-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Alt Tag on Newsroom Logo #4280
Comments
Hmmm, seems we just got report submitted from Accessibility lab thaaaat seems to validate this? Could the simple update to the Dynamic inclusion of the newsroom's name can be addressed in a subsequent ticket. Once we have the newsroom's name added to the admin interface, of course. And unicorns deliver burritos to my house from Mars. |
Bumpitty bump! Could this get a "Help Wanted" tag, and perhaps moved to "Near Term Backlog" per this AM's UX meeting? /cc @eloquence |
Happy to do so. Given latency in Tor, this ALT text does stick around for a while, and I agree there's some potential for confusion depending on what logo is actually set. How would you feel about "Logo Image" instead of just "Logo", at least until we qualify it with the newsroom name? The text "Logo" hovering for a few seconds I think has its own potential to look a bit confusing. |
Updated instructions in OG comment, accordingly—thx for the sound suggestion, Erik! |
Picking this up this week at @ninavizz 's reccomendation |
I'm picking this one up as suggested by @zenmonkeykstop on Gitter. I'll submit a PR shortly that just changes the static |
@DrGFreeman There is not currently a value in the Admin UI for an org to set their name; that would have to be added, for an |
…-static Changed newsroom logo alt tag to 'Logo Image' (#4280)
Description
Sought Immediate Action: Pls update
<alt>
tag on Newsroom Logo in Source UI to readLogo Image
and notSecureDrop
Currently there is no mention of the name of a newsroom on an instance of SecureDrop. This presents two core problems for Sources, in the Source Experience.
The
<alt>
on the newsroom logo today, is currentlySecureDrop
. That's strange and misleading. See 0:20 and 0:30 in this video screencast of AlJazeera's SecureDrop loading w/in Tor. A minimum/asap fix, would be updating the static<alt>
w/in the code to readNewsroom Logo
(sidenote: alt tags are a big accessibility thing, on an aside from also informing users what's what as assets load).Longer term, the Admin interface should be updated to accept the newsroom's name (including the word The for orgs such as The Intercept or The New York Times) and that alt-tag should be dynamically generated to read
<%NewsOrgName%> Logo
User Research Evidence
<alt>
recommendationsUser Stories
As a Source I want to be less confused about who I'm submitting my stuff to, and what this SecureDrop thing is.
The text was updated successfully, but these errors were encountered: