-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[xenial] fix errors in functional tests #4039
Comments
We can keep all of the functional tests fixed for now if we just use Firefox 46.0 like in Trusty. And then we can work on the Tor browser brunch on xenial to make it working here. Otherwise I have a PR (with ideas from the tbb branch) which fixes most of the issues, but, a few modal related ones are remaining. @redshiftzero thoughts? |
OK, we can go back to Firefox 46 to get them running. We can work on the Tor Browser branch, though I expect that the path to getting passing functional tests on xenial is shorter in separate PR than getting the huge TB branch merged |
We are getting back Firefox 46 and in future we will move to Tor Browser based tests for the functional test cases.
Fixes functional tests for #4039
We are getting back Firefox 46 and in future we will move to Tor Browser based tests for the functional test cases.
We are getting back Firefox 46 and in future we will move to Tor Browser based tests for the functional test cases.
Description
The functional tests need updating to run under Xenial. Don't expect them all to pass until all other xenial app code updates have been completed. This ticket is scoped just to getting them to either pass or fail under xenial - while not breaking them on trusty.
Optional: Current Tor Browser is based on Firefox ESR 60, so I would encourage updating both the trusty and xenial jobs to Firefox ESR 60 for consistency with what we want to be testing against.
Steps to Reproduce
make test-xenial
Expected Behavior
The tests either PASS or FAIL
Actual Behavior
All the functional tests ERROR, e.g.:
The text was updated successfully, but these errors were encountered: