Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xenial] fix errors in functional tests #4039

Closed
redshiftzero opened this issue Jan 16, 2019 · 2 comments · Fixed by #4090
Closed

[xenial] fix errors in functional tests #4039

redshiftzero opened this issue Jan 16, 2019 · 2 comments · Fixed by #4090

Comments

@redshiftzero
Copy link
Contributor

Description

The functional tests need updating to run under Xenial. Don't expect them all to pass until all other xenial app code updates have been completed. This ticket is scoped just to getting them to either pass or fail under xenial - while not breaking them on trusty.

Optional: Current Tor Browser is based on Firefox ESR 60, so I would encourage updating both the trusty and xenial jobs to Firefox ESR 60 for consistency with what we want to be testing against.

Steps to Reproduce

make test-xenial

Expected Behavior

The tests either PASS or FAIL

Actual Behavior

All the functional tests ERROR, e.g.:

tests/functional/test_journalist.py::TestJournalist::test_journalist_interface_ui_with_modal ERROR 
@kushaldas
Copy link
Contributor

We can keep all of the functional tests fixed for now if we just use Firefox 46.0 like in Trusty. And then we can work on the Tor browser brunch on xenial to make it working here. Otherwise I have a PR (with ideas from the tbb branch) which fixes most of the issues, but, a few modal related ones are remaining. @redshiftzero thoughts?

@redshiftzero
Copy link
Contributor Author

OK, we can go back to Firefox 46 to get them running. We can work on the Tor Browser branch, though I expect that the path to getting passing functional tests on xenial is shorter in separate PR than getting the huge TB branch merged

kushaldas added a commit that referenced this issue Jan 30, 2019
We are getting back Firefox 46 and in future we will move
to Tor Browser based tests for the functional test cases.
redshiftzero added a commit that referenced this issue Jan 30, 2019
zenmonkeykstop pushed a commit to zenmonkeykstop/securedrop that referenced this issue Feb 9, 2019
We are getting back Firefox 46 and in future we will move
to Tor Browser based tests for the functional test cases.
kushaldas added a commit that referenced this issue Sep 25, 2019
We are getting back Firefox 46 and in future we will move
to Tor Browser based tests for the functional test cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants