This repository has been archived by the owner on Jan 19, 2018. It is now read-only.
General config cleanup throughout build logic #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
April 25, 2017 21:54
These play-level vars should have been role defaults from the beginning, but they're no longer used, so removing them from the repo.
The role requires these vars, but they're not available within the context of the role. Let's move the vars into defaults, so they can be sanely overridden at the site level. Doing so will keep the playbook clean and neat in preparation for merging into the SecureDrop repo.
Reuse the apt cache for up to an hour, then refresh after that point. Don't refresh the apt cache on every build run, since it's highly unlikely that packages have changed. Additionally, use state=present for packages, rather than state=latest, since the latter forces an apt cache update every time.
Ansible is already smart enough to skip redownloading files via `get_url` if the destination file exists. One must declare the fullpath to the dest file, but we're already doing that. Unfortunately Ansible is *not* smart enough to update dest files in place if the checksum doesn't match, but that's why we have a hard fail on a subsequent task, to handle the checksum verification.
Now looping over the dest paths with file state=absent, which keeps the playbook output terser and makes the task list much more readable. Added an explanatory comment for future maintainers; you're welcome, future maintainer.
Mostly for consistency, but greatly adds in readability. The multiline YAML format matches what's already used in the SecureDrop repo, so making the change here in preparation for merging the repos.
Nicely formatted task names, including sentence capitalization and punctuation. No functional changes. In a few tasks, consolidated repetitive tasks with a `with_items` loop where appropriate.
|
👍 Nice clean-up task, successfully ran locally and got a tingling sensation. That means its working 😍 |
msheiny
approved these changes
Apr 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the formatting within the dedicated OSSEC build role to make the task list more readable, intuitive, and DRY. Does not affect build functionality. All the changes here are cosmetic, intended to match the formatting best practices already implemented in the freedomofpress/securedrop repository, in preparation for merging this repo into that one (freedomofpress/securedrop#1468).
One change not included here is namespacing of the role default vars; something like
securedrop_build_ossecseems appropriate, but that can be handled during repo merge.