Skip to content
This repository has been archived by the owner on Mar 2, 2024. It is now read-only.

Add mmap support #19

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

mscofield0
Copy link

To support concurrent modification, I used advisory locks. The downside being that the updater needs to also lock the file using an exclusive advisory lock.

The alternative is not worrying about such things and instead just manually restart the dictionary service when the dictionary is updated. It's a viable solution since I don't expect dictionaries updating quite often.

The only change made was the addition of MmapCursor as a Read + Seek reader that is then passed into either Uncompressed or Compressed dict readers. This maintains the interface established in #18.

@mscofield0
Copy link
Author

Depends on #18.
Related to #4.

@mscofield0 mscofield0 marked this pull request as draft April 14, 2022 13:15
@mscofield0
Copy link
Author

Index needs to have the same capability of updating to the newest version of the dictionary. Maybe check the metadata of the index file to see if it updated?

@humenda
Copy link
Member

humenda commented Apr 24, 2022 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants