This repository has been archived by the owner on Mar 2, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support concurrent modification, I used advisory locks. The downside being that the updater needs to also lock the file using an exclusive advisory lock.
The alternative is not worrying about such things and instead just manually restart the dictionary service when the dictionary is updated. It's a viable solution since I don't expect dictionaries updating quite often.
The only change made was the addition of
MmapCursor
as aRead + Seek
reader that is then passed into eitherUncompressed
orCompressed
dict readers. This maintains the interface established in #18.