2024 Crescendo VictiScout Update #211
Conversation
1ceit
requested review from
ErikBoesen,
MyaTaheri and
BenBerol
and removed request for
BenBerol
css/data.css
Outdated
| } | ||
| #transfer-button { | ||
| margin-left: 20px; | ||
| } | ||
| #HideTheseButtonsCuzItBreakIfIDelete{ |
There was a problem hiding this comment.
I would much prefer that you figure out why it's breaking and then resolve the breakage rather than keeping dead code around. Happy to help out if you give further clarification on what is going wrong when you remove the buttons in question.
| // Define <thead>, <tbody>, warning, and match deletion vars to be filled later on. | ||
| var thead = document.getElementsByTagName('thead')[0], | ||
| tbody = document.getElementsByTagName('tbody')[0], | ||
| warning = document.getElementById('warning'), | ||
|
|
||
| processingSection = document.getElementById('processing'), | ||
| fileInputButton = document.getElementById('input-file'), |
There was a problem hiding this comment.
Oh, this is why it's breaking if you delete that HTML code, because you're still trying to get the elements in the JS code
There was a problem hiding this comment.
I am aware of the JS get element. there are functions with in that are called that use the elements. I Spent about an hour trying to get it to work... I just was tired and hid it.
|
Anything I haven't resolved still needs to be fixed give me a bit and ill get it done :) |
|
I'm still a little hung up on the hidden inputs and I would prefer that this question gets resolved before merging. Do we not want to have support for merging and transferring files anymore? I would question this decision as I recall those being pretty fundamental features of the app and the primary reason for the data screen existing in the first place. But if we don't want them anymore, then we should remove them outright including the fairly substantial logic that manages them. |
Update to conform to game
- Add Type of drive
- Add Chasis Size (updateable in table view)
- Add Height (updateable in table view)
- Add Climb Method dropdown
- Add Auto Starting position dropdown
- Add Note Scoring
Add Shot Accuracy
- Add Auto Shot Accuracy field in table view
- Add Tele-Op Shot Accuracy field in table view
- Add Sort By Auto Shot Accuracy button in table view
- Add Sort By Tele-Op Shot Accuracy button in table view
Add Export to CSV button
Clean Up UI
- Hide Input file
- Hide Convert file
- Hide input file textbox
(Hides 10,000 px off the screen, breaks if deleted)
Fix Just use CSV by default instead of JSON #178, Checkboxes are off center #170