fix: redirect to FC dashboard when login to FC #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lms
|
||||||||||||||||||||||||||||||
| Project |
lms
|
| Branch Review |
billing-flow-changes
|
| Run status |
|
| Run duration | 00m 29s |
| Commit |
|
| Committer | Jannat Patel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
1
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
|
🎉 This PR is included in version 2.25.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a System Manager on an FC Trial Site, tried to login to FC from the portal, they were asked for a verification code, and that logged them into their FC dashboard. Also on clicking the Upgrade button from the Trial Card, they were redirected to another billing flow which was not a part of FC.
With the changes in this PR, when a System Manager now tries to Login to Frappe Cloud, they will be redirected to their Site Dashboard if they have added a payment method on FC, if not they will be redirected to the FC Welcome page. The same flow will be true if they click on the Upgrade button.