Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: misc batch issues #1327

Merged
merged 1 commit into from
Feb 19, 2025
Merged

fix: misc batch issues #1327

merged 1 commit into from
Feb 19, 2025

Conversation

pateljannat
Copy link
Collaborator

  1. Don't show past dates on the UI when scheduling evaluation The system is allowing users to schedule appointments for past dates. #1315
  2. Don't show the Register or Enroll Now button for a batch if the batch has started.
  3. Throw more errors if Live Class creation fails.

@cypress Cypress
Copy link

cypress bot commented Feb 19, 2025

lms    Run #1089

Run Properties:  status check passed Passed #1089  •  git commit b3735f6362 ℹ️: Merge 931104319027a1e7c2f338709d9b2f33a5a87874 into a8690e41e67b383b0dc644be768b...
Project lms
Branch Review issues-79
Run status status check passed Passed #1089
Run duration 00m 29s
Commit git commit b3735f6362 ℹ️: Merge 931104319027a1e7c2f338709d9b2f33a5a87874 into a8690e41e67b383b0dc644be768b...
Committer Jannat Patel
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎

@pateljannat pateljannat merged commit db4c742 into frappe:develop Feb 19, 2025
5 checks passed
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 2.24.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pateljannat @frappe-pr-bot