Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce Sales Invoice row size (backport #27136) #46151

Closed

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 26, 2025

Sales Invoice doctype is starting to hit row length limit as many integrations add custom fields on this doctype. This is just a small change to remove VARCHAR(140) fields and reduce row size wherever possible.

Changes:

  1. Where max length is known set it instead of default which is 140. E.g. Select type and "Scan Barcode" (which is a dummy field)
  2. Change Data to Small Text where field is only used for reference like customer name, amount in words.
    This is an automatic backport of pull request fix: reduce Sales Invoice row size #27136 done by Mergify.

Sales Invoice doctype is starting to hit row length limit as many
integrations add custom fields on this doctype. This is just a small
change to remove VARCHAR(140) fields and reduce row size wherever
possible.

(cherry picked from commit 8d116fb)

# Conflicts:
#	erpnext/accounts/doctype/sales_invoice/sales_invoice.json
Copy link
Contributor Author

mergify bot commented Feb 26, 2025

Cherry-pick of 8d116fb has failed:

On branch mergify/bp/version-13-hotfix/pr-27136
Your branch is up to date with 'origin/version-13-hotfix'.

You are currently cherry-picking commit 8d116fb9ff.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   erpnext/accounts/doctype/sales_invoice/sales_invoice.json

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot assigned ankush Feb 26, 2025
@ankush ankush closed this Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant