-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Egui text input #312
Egui text input #312
Conversation
c30561f
to
84059ff
Compare
Codecov Report
@@ Coverage Diff @@
## devel #312 +/- ##
===========================================
- Coverage 76.37% 45.22% -31.15%
===========================================
Files 155 154 -1
Lines 25846 24805 -1041
===========================================
- Hits 19739 11218 -8521
- Misses 6107 13587 +7480
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor notes/questions. otherwise looks good.
Must implement hasCompose()
Avoid allocating new memory when the backend string has enough capacity.
It works but they are some duplicated code parts
6e74ca9
to
d093cf6
Compare
Implement
UI.TextInput
(single line for now).It supports having a mutable or immutable initial value. In case a non-existing variable is given, it will expose it.
Manipulating the
dyn TextBuffer
is optimized to only clone when the string capacity is not sufficient. Otherwise it does pointer arithmetic to move slices of memory around.