Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 1.1.0 to set in package.json ? #219

Closed
eden91940 opened this issue Nov 12, 2022 · 2 comments · Fixed by #228
Closed

Version 1.1.0 to set in package.json ? #219

eden91940 opened this issue Nov 12, 2022 · 2 comments · Fixed by #228

Comments

@eden91940
Copy link

forge-std/package.json

Line 3 in 33d4895

"version": "1.0.0",

@ZeroEkkusu
Copy link
Collaborator

If the version is in package.json doesn’t matter, we can also set it to ”V1”.

@mds1
Copy link
Collaborator

mds1 commented Nov 12, 2022

Since we're not publishing to NPM currently, this doesn't matter much, but it will matter if/when we do start publishing to npm (#39, #170). So let's PR in a change to "1.1.0" to keep it in sync for good measure, but I don't think we need to do a new release/tag just for this

@ZeroEkkusu ZeroEkkusu mentioned this issue Nov 17, 2022
Merged
mds1 added a commit that referenced this issue Nov 19, 2022
@mds1
chore: v1.2.0 will be the next release
4eaa911 
accidentally skipped v1.1.0 in package.json, see #219
mds1 added a commit that referenced this issue Nov 19, 2022
@mds1
chore: bump version to v1.2.0 (the upcoming release)
bb88876 
accidentally skipped v1.1.0 in package.json, see #219
@mds1 mds1 mentioned this issue Nov 19, 2022
Merged
mds1 added a commit that referenced this issue Dec 15, 2022
@mds1
chore: bump version to v1.2.0 (the upcoming release)
2fa3d08 
accidentally skipped v1.1.0 in package.json, see #219
mds1 added a commit that referenced this issue Dec 15, 2022
@mds1
chore: bump version to v1.2.0 (the upcoming release) (#228)
a414a03 
accidentally skipped v1.1.0 in package.json, see #219
@mds1 mds1 closed this as completed in #228 Dec 15, 2022
thomas-lamb-tech pushed a commit to thomas-lamb-tech/std_forge that referenced this issue Dec 26, 2024
@mds1
chore: bump version to v1.2.0 (the upcoming release) (#228)
ac5ca1c 
accidentally skipped v1.1.0 in package.json, see foundry-rs/forge-std#219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: bump version to v1.2.0 (the upcoming release) foundry-rs/forge-std
3 participants
@eden91940 @mds1 @ZeroEkkusu