Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better dependecy handling #106

Merged

Conversation

BengtRydberg
Copy link
Contributor

This PR improves the dependency handling.

If you install the package by pip install . only some default packages will be installed needed for the most important script of the level1c4pps package.

If you install it by pip install .[extra] you will install some additional packages needed for some specific satpy readers.

I am not totally sure which readers that should installed by default, so comments are welcome.

Note that level1c4pps utilises more readers than it looks like in the modified setup.py file as we only need to specify the readers that requires a non default satpy installation.

@coveralls
Copy link

coveralls commented Jan 10, 2025

Pull Request Test Coverage Report for Build 13053826588

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 21 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 78.146%

Files with Coverage Reduction New Missed Lines %
level1c4pps/tests/test_viirs2pps.py 2 84.21%
level1c4pps/init.py 7 85.78%
level1c4pps/viirs2pps_lib.py 12 48.15%
Totals Coverage Status
Change from base Build 12688079447: -0.1%
Covered Lines: 1648
Relevant Lines: 2061

💛 - Coveralls

setup.py Outdated
"satpy[avhrr_l1b_eps,viirs_l1b,viirs_sdr,viirs_compact]!=0.38.*,!=0.39.*,!=0.40.*,!=0.41.*",
]
extras_requires = {
"extra": "satpy[avhrr_l1b_gaclac,seviri_l1b_hrit,seviri_l1b_native,seviri_l1b_nc,vii_l1b_nc]"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that it is possible to separate this further if desired, e.g.:

extras_requires = {
     "gaclac": "satpy[avhrr_l1b_gaclac]",
     "seviri": "satpy[seviri_l1b_hrit,seviri_l1b_native,seviri_l1b_nc]",
     "metimage": "satpy[vii_l1b_nc]",
}


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the further specification is good.

Copy link
Contributor Author

@BengtRydberg BengtRydberg Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added more options.

@ninahakansson ninahakansson merged commit a991af4 into foua-pps:main Feb 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants