SEVIRI IR calibration #105
Conversation
Pull Request Test Coverage Report for Build 13200241166Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
level1c4pps/calibration_coefs.py
Outdated
| @@ -164,4 +191,9 @@ def _microwatts_to_milliwatts(microwatts): | |||
| time=time) | |||
| coefs[channel] = {'gain': gain, 'offset': offset} | |||
|
|
|||
| for channel in ('IR_039', 'IR_087', 'IR_108', 'IR_120', | |||
| 'IR_134', 'IR_097', 'WV_062', 'WV_073'): | |||
| gain, offset = ir_calib_eumetsat(platform=platform, channel=channel, | |||
There was a problem hiding this comment.
no need to define gain and offset, just do
coefs[channel] = ir_calib_eumetsat(platform=platform, channel=channel,
But why is this piece of code present here at all within the __main__ part of the module. Seems like a leftover of some manual testing to me?
level1c4pps/calibration_coefs.py
Outdated
| @@ -74,6 +75,15 @@ def get_calibration(platform, time, clip=False): | |||
| time=time, | |||
| clip=clip | |||
| ) | |||
| if path_to_external_ir_calibration is not None: | |||
There was a problem hiding this comment.
maybe make more sense to create the full file path after this line, then in function that is called?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
- Coverage 76.59% 76.22% -0.37%
==========================================
Files 23 23
Lines 1726 1775 +49
Branches 159 162 +3
==========================================
+ Hits 1322 1353 +31
- Misses 359 379 +20
+ Partials 45 43 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Use external IR calibration from json files.
pytest level1c4ppsflake8