feat(upload): added the upload file page #46

Shruti3004 · 2021-06-28T10:54:30Z

Description

Added the upload file page.

Changes

Created the separate folder for uploads in Components that contains helper functions which will get reused in VCS, Url and server.
- AccessLevel
- Ignore Scm
- License Decider
- Optional Analysis
- Upload Reuse
Added the Upload file page

How to test

visit to the route '/upload/file'

Screenshots

Shruti3004 · 2021-06-28T11:40:37Z

@GMishx current implementation is perfectly creating a file, But there is one question regarding the dropdown of select folder, I have implemented it like the way I did with search as suggested by you, by default I have provided it with the Id, is it the right approach? And for the time being we decided to wrap with all the uploads api then we will work on jobs api for scanning the uploaded documents, What's your call on this?

GMishx · 2021-06-28T12:05:35Z

@GMishx current implementation is perfectly creating a file, But there is one question regarding the dropdown of select folder, I have implemented it like the way I did with search as suggested by you, by default I have provided it with the Id, is it the right approach?

You can check #45, @Aman-Codes is loading them.

And for the time being we decided to wrap with all the uploads api then we will work on jobs api for scanning the uploaded documents, What's your call on this?

Okay, lets check the REST API and discuss this in the meeting. There is a possibility to do it in single call.

Shruti3004 · 2021-06-28T12:13:44Z

@GMishx current implementation is perfectly creating a file, But there is one question regarding the dropdown of select folder, I have implemented it like the way I did with search as suggested by you, by default I have provided it with the Id, is it the right approach?

You can check #45, @Aman-Codes is loading them.

And for the time being we decided to wrap with all the uploads api then we will work on jobs api for scanning the uploaded documents, What's your call on this?

Okay, lets check the REST API and discuss this in the meeting. There is a possibility to do it in single call.

Okay Sure.

Shruti3004 · 2021-06-29T11:27:01Z

@GMishx I have added the jobs api as well for scheduling analysis of uploaded files please review it.

src/Routes.js

src/api/upload.js

GMishx · 2021-06-30T06:00:52Z

src/components/Upload/CommonFields/UploadReuse/index.js

+      >
+        Select an already uploaded package for reuse in specific folder
+      </InputContainer>
+      <select>
+        <option value="Software Repository">Software Repository</option>


This can be fetched with combination of /folders and /uploads endpoints.

src/components/Upload/CommonFields/UploadReuse/index.js

src/components/Widgets/Input/index.js

GMishx · 2021-06-30T06:09:48Z

The file got uploaded successfully but the uploadid for the jobs was undefined. Also, please clear the form once the form is submitted to prevent duplicate uploads.

Signed-off-by: Shruti3004 <mail2shruti.ag@gmail.com>

Shruti3004 · 2021-07-01T02:19:27Z

@GMishx In yesterday meeting we had a discussion regarding creating the label named urgent, actually this pr has massive changes so when I rebase it yesterday, on rebasing it overwrites the code twice, then again i copy the file from my commit, this leads to increase the work and time wastage. So, unamously we reached to a conclusion that we can have this label for such prs.

GMishx · 2021-07-01T08:52:52Z

@GMishx In yesterday meeting we had a discussion regarding creating the label named urgent, actually this pr has massive changes so when I rebase it yesterday, on rebasing it overwrites the code twice, then again i copy the file from my commit, this leads to increase the work and time wastage. So, unamously we reached to a conclusion that we can have this label for such prs.

Thank you for letting me know about the label but I can only do so much working as a single maintainer reviewing the PRs :-).

Also, there are many changes that needs to be done before I can merge this PR, so I left the review comments. You want to merge it now and resolve them in a separate issue?

GMishx · 2021-07-01T08:55:22Z

src/constants/endpoints.js

@@ -36,4 +36,9 @@ export const endpoints = {
    create: () => `${apiUrl}/folders`,
    delete: (folderId) => `${apiUrl}/folders/${folderId}`,
  },
+  upload: {
+    uploadCreate: () => `${apiUrl}/uploads`,
+    scheduleAnalysis: () => `${apiUrl}/jobs`,


Shouldn't it be part of jobs object?

Yes, we have to fix it once we hop on jobs section then we will keep all the related apis to it in that.

Signed-off-by: Shruti3004 <mail2shruti.ag@gmail.com>

Shruti3004 · 2021-07-01T08:59:34Z

@GMishx In yesterday meeting we had a discussion regarding creating the label named urgent, actually this pr has massive changes so when I rebase it yesterday, on rebasing it overwrites the code twice, then again i copy the file from my commit, this leads to increase the work and time wastage. So, unamously we reached to a conclusion that we can have this label for such prs.

Thank you for letting me know about the label but I can only do so much working as a single maintainer reviewing the PRs :-).

Also, there are many changes that needs to be done before I can merge this PR, so I left the review comments. You want to merge it now and resolve them in a separate issue?

Yes, I understand, @GMishx I have no issue adding the changes in this pr itself but the thing is on rebasing the coding is getting overwritten, is there is any other way to resolve that.

GMishx · 2021-07-01T09:01:28Z

Yes, I understand, @GMishx I have no probblem resolving in this pr itself but the thing is on rebasing the coding is getting overwritten, is there is any other way to resolve tht

Only way to prevent this situation is I do not merge any other branch till the branch marked with urgent tags are merged.

GMishx

Changes looks good.
Tested, working fine.

Just a request if the form can be reloaded or cleaned once the "Upload" is done, I can merge this PR.

Shruti3004 · 2021-07-01T09:05:02Z

Changes looks good.
Tested, working fine.

Just a request if the form can be reloaded or cleaned once the "Upload" is done, I can merge this PR.

Sir I have set that wont it working for you? The checkmarks get clear and probably you are seeing that file name but it is just displaying if you try creating it without adding file it will fail.

GMishx · 2021-07-01T09:09:48Z

Oh, my bad. Didn't pull the code.

Shruti3004 requested a review from GMishx June 28, 2021 10:58

Shruti3004 force-pushed the feat/upload-file branch from cb9c1e1 to 6b8a3f6 Compare June 29, 2021 11:25

Shruti3004 requested a review from shaheemazmalmmd June 29, 2021 11:28

GMishx added needs review Need code review needs test Needs testing labels Jun 30, 2021

GMishx requested changes Jun 30, 2021

View reviewed changes

Shruti3004 force-pushed the feat/upload-file branch 2 times, most recently from 903ec76 to df22b97 Compare June 30, 2021 19:34

feat(upload): added the upload file page

d45c5d3

Signed-off-by: Shruti3004 <mail2shruti.ag@gmail.com>

Shruti3004 force-pushed the feat/upload-file branch from df22b97 to d45c5d3 Compare June 30, 2021 19:45

Shruti3004 added the urgent Needs an immediate review label Jun 30, 2021

Shruti3004 force-pushed the feat/upload-file branch from 4dd7ce1 to 8e5513c Compare July 1, 2021 02:07

GMishx reviewed Jul 1, 2021

View reviewed changes

feat(analysis): added the analysis request

6ef8e7d

Signed-off-by: Shruti3004 <mail2shruti.ag@gmail.com>

Shruti3004 force-pushed the feat/upload-file branch from 8e5513c to 6ef8e7d Compare July 1, 2021 08:56

GMishx approved these changes Jul 1, 2021

View reviewed changes

GMishx added ready PR is ready for merge and removed needs review Need code review needs test Needs testing labels Jul 1, 2021

GMishx merged commit 1c5c66c into development Jul 1, 2021

GMishx deleted the feat/upload-file branch July 1, 2021 09:10

Shruti3004 mentioned this pull request Aug 6, 2021

fix(jobs): fixed the jobs api of scheduleAnalysis #145

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(upload): added the upload file page #46

feat(upload): added the upload file page #46

Shruti3004 commented Jun 28, 2021 •

edited

Loading

Shruti3004 commented Jun 28, 2021

GMishx commented Jun 28, 2021

Shruti3004 commented Jun 28, 2021

Shruti3004 commented Jun 29, 2021

GMishx Jun 30, 2021

GMishx commented Jun 30, 2021

Shruti3004 commented Jul 1, 2021 •

edited

Loading

GMishx commented Jul 1, 2021

GMishx Jul 1, 2021

Shruti3004 Jul 1, 2021

Shruti3004 commented Jul 1, 2021 •

edited

Loading

GMishx commented Jul 1, 2021

GMishx left a comment

Shruti3004 commented Jul 1, 2021 •

edited

Loading

GMishx commented Jul 1, 2021

feat(upload): added the upload file page #46

feat(upload): added the upload file page #46

Conversation

Shruti3004 commented Jun 28, 2021 • edited Loading

Description

Changes

How to test

Screenshots

Shruti3004 commented Jun 28, 2021

GMishx commented Jun 28, 2021

Shruti3004 commented Jun 28, 2021

Shruti3004 commented Jun 29, 2021

GMishx Jun 30, 2021

Choose a reason for hiding this comment

GMishx commented Jun 30, 2021

Shruti3004 commented Jul 1, 2021 • edited Loading

GMishx commented Jul 1, 2021

GMishx Jul 1, 2021

Choose a reason for hiding this comment

Shruti3004 Jul 1, 2021

Choose a reason for hiding this comment

Shruti3004 commented Jul 1, 2021 • edited Loading

GMishx commented Jul 1, 2021

GMishx left a comment

Choose a reason for hiding this comment

Shruti3004 commented Jul 1, 2021 • edited Loading

GMishx commented Jul 1, 2021

Shruti3004 commented Jun 28, 2021 •

edited

Loading

Shruti3004 commented Jul 1, 2021 •

edited

Loading

Shruti3004 commented Jul 1, 2021 •

edited

Loading

Shruti3004 commented Jul 1, 2021 •

edited

Loading