Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding space in between the skill bubble on the skill page in mobile view #3553

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

Adding space in between the skill bubble on the skill page in mobile view #3553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/cms/SkillPage/SkillListing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const Paper = styled(_Paper)`
`;

const ExampleWrapper = styled.div`
width: 55%;
width: 100%;
display: flex;
flex-wrap: wrap;
flex-direction: row;
Expand Down Expand Up @@ -359,7 +359,7 @@ class SkillListing extends Component {
key={index}
data={data}
history={history}
margin={'1.5% 2.85% 1.5% 0'}
margin={'12px 10px 12px 0'}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why pixles insted of percentage ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Percentage is a relative unit. So, the margin will change according to the screen of size.On a really small screen like a phone that might be appropriate. But if you're viewing that same page on a bigger size screen, that margin is going to be huge if we use percentage. That's why I've used pixels to maintain the same gap between them.

/>
);
})}
Expand Down