Fix SOCKS Target Parsing #1843
Merged
Fix SOCKS Target Parsing #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes fortra#1575 by parsing the target hostname correctly from commands run through ntlmrelayx's socks5 proxy.
Fix hostname parsing
|
For clarity: as mentioned in the linked issue, the socks functionality of NTLMRelayx is broken when targets are specified by hostname instead of IP. This PR fixes the issue. Targeting machines by hostname instead of IP is preferable in some cases. Such as when targeting a group of workstations and laptops configured with DHCP where a specific user has local admin. It also makes large target files more readable, especially when a naming convention is followed for hostnames. |
|
thanks @gjhami, I'll take care of this one |
|
thanks for the PR, merging now |
Ridter
pushed a commit
to Ridter/impacket
that referenced
this pull request
Feb 26, 2025
* Update socksserver.py Fixes fortra#1575 by parsing the target hostname correctly from commands run through ntlmrelayx's socks5 proxy. * Update socksserver.py Fix hostname parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1575 by parsing the target hostname correctly from commands run through ntlmrelayx's socks5 proxy.