Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to pass commands to mssqlclient.py via command line #1770

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

trietend
Copy link
Contributor

@trietend trietend commented Jul 2, 2024

allow to pass commands to mssqlclient.py via the command line directly instead of only using a input file

@anadrianmanrique anadrianmanrique added the in review This issue or pull request is being analyzed label Jul 11, 2024
@gabrielg5 gabrielg5 added medium Medium priority item and removed in review This issue or pull request is being analyzed labels Sep 26, 2024
Copy link
Collaborator

@gabrielg5 gabrielg5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @trietend,

Just a tiny change to align the new parameter with similar ones in other examples, like:

  • impacket/examples/goldenPac.py

    Lines 1083 to 1085 in af51dfd

    parser.add_argument('command', nargs='*', default=' ',
    help='command (or arguments if -c is used) to execute at the target (w/o path). Defaults to '
    'cmd.exe. \'None\' will not execute PSEXEC (handy if you just want to save the ticket)')
  • parser.add_argument('command', nargs='*', default=' ', help='command to execute at the target. If empty it will '
    'launch a semi-interactive shell')

Thanks!

@gabrielg5 gabrielg5 added the waiting for response Further information is needed from people who opened the issue or pull request label Dec 5, 2024
Co-authored-by: Gabriel Gonzalez <gabriel.gonzalez@fortra.com>
@trietend trietend requested a review from gabrielg5 December 6, 2024 10:56
Copy link
Collaborator

@gabrielg5 gabrielg5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trietend!
(commited the other suggestion, updating use of new parameter name :) )

Merging, thank you!!

@gabrielg5 gabrielg5 merged commit e9a47ff into fortra:master Dec 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Medium priority item waiting for response Further information is needed from people who opened the issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants