Fix quick settings implementation on GNOME 43-44 #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmmaranan
force-pushed
the
fix-qs-title-prop
branch
from
25b6afa to
ae3673e
Compare
jmmaranan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #235
Background: GNOME introduced quick settings in Gnome 43 and following their guide some features are not available in between 43 and 44: https://gjs.guide/extensions/topics/quick-settings.html
I added an issue in GJS Docs if they can put a warning for anyone who stumbles upon it in their examples and find that it is missing in GNOME 43.
https://gitlab.gnome.org/ewlsh/gjs-guide/-/issues/64