Test and Test App Cleanup #2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brandonpage
commented
Oct 21, 2024
brandonpage
commented
- Fixed Server Picker UI tests.
- Downgraded hybrid test apps to API 34 to avoid Edge to Edge issues.
- Fixed Edge to Edge issues on native test apps.
- Fixed a couple AndroidManifest issues with test apps.
… to Edge issues in native apps.
brandonpage
commented
Oct 21, 2024
Comment on lines
+303
to
+305
| if (!SalesforceSDKManager.getInstance().getIsTestRun()) { | ||
| startActivity(intent); | ||
| } |
There was a problem hiding this comment.
I really don't love this, but it seems to be the only way to get the tests to run consistently.
brandonpage
commented
Oct 21, 2024
| @@ -26,7 +26,6 @@ | |||
| */ | |||
| package com.salesforce.samples.restexplorer; | |||
|
|
|||
| import static androidx.test.InstrumentationRegistry.getInstrumentation; | |||
There was a problem hiding this comment.
Every change in this class is either fixing a warning or changing Thread.sleep to device.waitForIdle (which speeds things up).
Tests results for SmartStoreGenerated by 🚫 Danger |
Tests:
Tests results for SalesforceHybridGenerated by 🚫 Danger |
wmathurin
approved these changes
Oct 22, 2024
Tests results for MobileSyncGenerated by 🚫 Danger |
Tests results for SalesforceSDKGenerated by 🚫 Danger |
Tests results for SalesforceReactGenerated by 🚫 Danger |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2630 +/- ##
============================================
- Coverage 58.91% 58.87% -0.04%
Complexity 2452 2452
============================================
Files 189 189
Lines 15432 15474 +42
Branches 1997 1998 +1
============================================
+ Hits 9091 9111 +20
- Misses 5413 5431 +18
- Partials 928 932 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.