@W-16797266: [TRUST] Ensure all WorkManager Jobs have an associated tag or unique name #2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ag or unique name
| @@ -49,7 +49,6 @@ import com.salesforce.androidsdk.push.PushMessaging.getRegistrationId | |||
| import com.salesforce.androidsdk.push.PushMessaging.setRegistrationId | |||
| import com.salesforce.androidsdk.push.PushMessaging.setRegistrationInfo | |||
| import com.salesforce.androidsdk.push.PushNotificationsRegistrationChangeWorker.PushNotificationsRegistrationAction | |||
| import com.salesforce.androidsdk.push.PushNotificationsRegistrationChangeWorker.PushNotificationsRegistrationAction.Deregister | |||
There was a problem hiding this comment.
I confirmed this was an unused import. It wasn't used in the logic on dev in this source. It is used elsewhere, though.
brandonpage
approved these changes
Oct 18, 2024
Tests results for SalesforceSDKGenerated by 🚫 Danger |
Tests:
Tests results for SmartStoreGenerated by 🚫 Danger |
Tests results for SalesforceReactGenerated by 🚫 Danger |
JohnsonEricAtSalesforce
merged commit ebe43e3
into
forcedotcom:dev
5 of 9 checks passed
JohnsonEricAtSalesforce
deleted the
feature/w-16797266_trust-ensure-all-workmanager-jobs-have-an-associated-tag-or-unique-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤘🏻 Ready For Review! 🎸
This simple Trust update ensures the Android Background Tasks library will not be used to create duplicate work.