Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W-16498231: [MSDK Android] Native User Registration No Longer Sets User's Initial Password #2602

Conversation

JohnsonEricAtSalesforce
Copy link
Contributor

🎸 Ready For Review! 🥁

This simple and low risk bug fix simply moves the password parameter in start user registration to where the Salesforce Identity API expects (now) according to the documentation.

I've tested this using the AndroidNativeLoginTemplate and ensured the user's new password works as expected after registration.

@mobilesdk-bot
Copy link

1 Error
🚫 Tests have failed, see below for more information.
1 Warning
⚠️ No Lint Results.

Tests:

Name Classname Time
test[testCleanResyncGhosts] com.salesforce.androidsdk.reactnative.ReactMobileSyncTest 132.6

Tests results for SalesforceReact

Generated by 🚫 Danger

@mobilesdk-bot
Copy link

1 Error
🚫 Tests have failed, see below for more information.

Tests:

Name Classname Time
testCleanGhostsOneObjectType com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 1.375
testSyncDownFetchingOneObjectType com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 1.98
testSyncDownFetchingTwoObjectTypes com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 4.311
testIdsToSkip com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 1.783
testStartFetchWithMaxTimeStamp com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 3.657
testCleanGhostsTwoObjectTypes com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 1.795
testSyncDownFetchingOneObjectTypeWithMultipleRetrieveCalls com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 1.949
testStartFetchNoMaxTimeStamp com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 2.687
testSyncDownFetchingTwoObjectTypesWithMultipleRetrieveCalls com.salesforce.androidsdk.mobilesync.target.BriefcaseSyncDownTargetTest 3.869

Tests results for MobileSync

Generated by 🚫 Danger

@JohnsonEricAtSalesforce JohnsonEricAtSalesforce merged commit 94fcfdc into forcedotcom:dev Aug 15, 2024
6 of 9 checks passed
@JohnsonEricAtSalesforce JohnsonEricAtSalesforce deleted the bugfix/w-16498231_msdk-android-native-user-registration-no-longer-sets-users-initial-password branch August 15, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants