Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally support use custom domain button in webview. #2447

Merged
merged 7 commits into from
Aug 25, 2023
Merged

Optionally support use custom domain button in webview. #2447

merged 7 commits into from
Aug 25, 2023

Conversation

brandonpage
Copy link
Contributor

@brandonpage brandonpage commented Aug 10, 2023 •
edited
Loading

  • Opt-in regex pattern to specify domains.
  • If a valid url is entered via the "Use Custom Domain" button on the login page store it in the server list.
  • Open custom domain urls in Chrome (advanced auth) if appropriate.

@mobilesdk-bot
Copy link

1 Warning
⚠️ No Lint Results.

Tests results for

Generated by 🚫 Danger

wmathurin
wmathurin reviewed Aug 25, 2023
View reviewed changes
libs/SalesforceSDK/src/com/salesforce/androidsdk/ui/OAuthWebviewHelper.java
if (SalesforceSDKManager.getInstance().shouldInferCustomDomain() && isNewLoginUrl(uri)) {
String host = uri.getHost();
Pattern customDomainPattern = SalesforceSDKManager.getInstance().getCustomDomainInferencePattern();
if (host != null && !getLoginUrl().contains(host) && customDomainPattern != null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing with iOS, should we have a flag like domainUpdated, or is that achieved by setting the login server which causes getLoginUrl().contains(host) to be true if you are back here a second time?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getLoginUrl checks the currently selected login server so it should server the same purpose.

@wmathurin
Copy link
Contributor

Maybe we should rename the PR from "Fully support use custom domain button in webview" to "Optionally support use custom domain in webview" ;-)

@brandonpage brandonpage changed the title Fully support use custom domain button in webview. Optionally support use custom domain button in webview. Aug 25, 2023
@brandonpage brandonpage merged commit 702159b into forcedotcom:dev Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmathurin wmathurin wmathurin approved these changes

@bbirman bbirman Awaiting requested review from bbirman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brandonpage @mobilesdk-bot @wmathurin @bbirman