@W-13610752: LoginActivity UI appears different in 11.0 #2427
Conversation
Tests results forGenerated by 🚫 Danger |
| @@ -2,7 +2,9 @@ | |||
|
|
|||
| <resources xmlns:android="http://schemas.android.com/apk/res/android"> | |||
|
|
|||
| <style name="SalesforceSDK" parent="Theme.AppCompat.DayNight"> | |||
| <style name="SalesforceSDK" parent="Theme.AppCompat.Light.DarkActionBar"> | |||
There was a problem hiding this comment.
Now that I really looked over the 10.2 theme for the app bar, it qualifies as "dark" since it always uses white text on blue, regardless of light or dark mode.
| @@ -2,7 +2,9 @@ | |||
|
|
|||
| <resources xmlns:android="http://schemas.android.com/apk/res/android"> | |||
|
|
|||
| <style name="SalesforceSDK" parent="Theme.AppCompat.DayNight"> | |||
| <style name="SalesforceSDK" parent="Theme.AppCompat.Light.DarkActionBar"> | |||
| <item name="colorPrimary">@color/sf__primary_color</item> | |||
There was a problem hiding this comment.
AppCompat picks up these two colors from a different attribute set, so I is necessary to have both colorPrimary and android:colorPrimary.
…untSwitcherActivity`)
| @@ -46,7 +47,7 @@ | |||
| * | |||
| * @author bhariharan | |||
| */ | |||
| public class AccountSwitcherActivity extends Activity { | |||
| public class AccountSwitcherActivity extends AppCompatActivity { | |||
There was a problem hiding this comment.
I was doing another test and realized AccountSwitcherActivity also uses the SalesforceSDK style for its theme. Without being an AppCompatActivity, it wouldn't display the AppCompat provided action bar.
This one seems to reparent without any other issues.
|
We might need to be on the lookout for other activities whose action bar behavior has changed where ever the |
…rts In `DevInfoActivity`)
|
For testing records, I verified |
…e Of `ManageSpaceActivity`)
JohnsonEricAtSalesforce
deleted the
bugfix/w-13610752-app-compat-activity-app-bar-styling
branch
🥁 Ready for review 🎸
This updates the
SalesforceSDKstyle so that our MSDK 11 updates usingAppCompatActivitywill theme exactly as they do in 10.2.0. This applies to both light and dark modes plus all the activities in the sample apps. Also, this ensures the theme is the same API 24 to current.I tested this side-by-side with 10.2.0 in MobileSyncExplorer in login activity and all the other activities in the sample app.