Add Screen Lock Timeout #2335
Add Screen Lock Timeout #2335
Conversation
Generated by 🚫 Danger |
Tests results for SalesforceSDKGenerated by 🚫 Danger |
| boolean hasLock = sharedPrefs.getBoolean(SCREEN_LOCK, false); | ||
| int timeout = sharedPrefs.getInt(SCREEN_LOCK_TIMEOUT, 0); | ||
|
|
||
| return hasLock && (elapsedTime > timeout); |
There was a problem hiding this comment.
Should this also be checking if lastLockedTimestamp != 0?
unlock() sets lastLockedTimestamp to 0 but that would mean that unlock would guarantee that elapsedTime > timeout is true (unless someone set a timeout greater than 2022 years or something)
There was a problem hiding this comment.
No. I explicitly want this to return true when lastLockedTimestamp is 0 upon initial login. If the connected app tells us the user requires the lock they should have to demonstrate it once to finish the login process. lastLockedTimestamp should be captured on background any other time except cold boot, which should start locked.
There was a problem hiding this comment.
That makes sense to me, but I'm still unclear what the purpose of the unlock() function is. It looks like it will lock the app instead of unlocking, is that correct?
There was a problem hiding this comment.
unlock() was a bad name for that method because it was only used to setup for the next shouldLock call on unlock. I have updated the code path where this setup was needed and deprecated unlock. Thanks for pointing this out.
No description provided.