Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the current images projects list #557

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Conversation

gdubicki
Copy link
Contributor

@gdubicki gdubicki commented Dec 4, 2021

as returned by
gcloud compute images list | cut -c55-75 \ | grep -v PROJECT | sort | uniq

as returned by
`gcloud compute images list | cut -c55-75 \
| grep -v PROJECT | sort | uniq`
gdubicki added a commit to gdubicki/vagrant-google that referenced this pull request Dec 4, 2021
and correct info that providing image_project_id is required
- it is not, if the image is a standard one (and the list
of global projects in fog/fog-google is up to date, see
fog/fog-google#557)

Fixes mitchellh#228
@gdubicki
Copy link
Contributor Author

gdubicki commented Dec 4, 2021

It would be more future-proof to get this list from GCP API dynamically, but I don't know this project well enough to propose such a change, sorry.

@gdubicki
Copy link
Contributor Author

@icco , @Temikus , @plribeiro3000

@Temikus Temikus merged commit d158969 into fog:master Dec 20, 2021
@Temikus
Copy link
Member

Temikus commented Dec 20, 2021

Thanks ❤️

@gdubicki gdubicki deleted the patch-2 branch December 20, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants