Improve Compute coverage #394

Temikus · 2018-07-14T07:53:46Z

Server is our most complicated model but it has the worst test coverage.
This is trying to improve it and fix the docs while I'm at it.

Due to the need to instantiate a bunch of servers during the test this slows them down quite a bit...
Looking at ballpark figures - 73 minutes :|

I'll start thinking about speeding things up. I think we can parallelise things more, but that requires careful planning of cleanup (since different API's can trump eachother).

Temikus · 2018-07-14T11:44:45Z

Something's up with GitHub - PR's no longer update :|

Wrote to support - I'll revisit this tomorrow.

codecov · 2018-07-15T00:28:11Z

Codecov Report

Merging #394 into master will increase coverage by 2.05%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #394      +/-   ##
==========================================
+ Coverage   83.44%   85.49%   +2.05%     
==========================================
  Files         339      114     -225     
  Lines        5762     2117    -3645     
==========================================
- Hits         4808     1810    -2998     
+ Misses        954      307     -647

Impacted Files	Coverage Δ
lib/fog/google/models/sql/instance.rb	`65.57% <0%> (-13.94%)`	⬇️
lib/fog/google/models/sql/user.rb	`46.42% <0%> (-50%)`	⬇️
lib/fog/google/models/sql/ssl_certs.rb	`45% <0%> (-35%)`	⬇️
lib/fog/google/models/sql/ssl_cert.rb	`54.28% <0%> (-34.29%)`	⬇️
lib/fog/google/requests/sql/update_instance.rb	`58.33% <0%> (-33.34%)`	⬇️
lib/fog/google/models/sql/tiers.rb	`80% <0%> (-20%)`	⬇️
lib/fog/google/models/sql/users.rb	`80% <0%> (-20%)`	⬇️
...fog/google/requests/sql/restore_instance_backup.rb	`70% <0%> (-20%)`	⬇️
lib/fog/google/requests/sql/delete_ssl_cert.rb	`77.77% <0%> (-11.12%)`	⬇️
... and 218 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72ae50e...ecfdfd2. Read the comment docs.

houndci-bot · 2018-07-15T01:22:48Z

test/integration/factories/collection_factory.rb

+    # Grab the test suit name from the example
+    suit_name = [@example].join("_").gsub(/\W/, "").tr("_", "-").downcase.split('-')[0]
+    # Select all resources matching the test suite
+    resources = @subject.all.select { |resource| resource.name.match? /#{PREFIX}-[0-9]*-#{suit_name}/ }


Lint/AmbiguousRegexpLiteral: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the / if it should be a division.

houndci-bot · 2018-07-15T01:22:48Z

test/integration/factories/collection_factory.rb

@@ -8,7 +8,10 @@ def initialize(subject, example)
  end

  def cleanup(async = false)
-    resources = @subject.all.select { |resource| resource.name.start_with? PREFIX }
+    # Grab the test suit name from the example
+    suit_name = [@example].join("_").gsub(/\W/, "").tr("_", "-").downcase.split('-')[0]


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

This should be mostly a no-op, just a logical improvement. Waiting for !PENDING may cause some issues when operation is in a transitional state or they add another status to an operation on the backend.

This will make it easier to spot long-running tests and get results from CI quicker.

In theory this isn’t even needed as the bottom routine actually waits for resources to disappear from the listing: ``` resources.each { |r| Fog.wait_for { !@subject.all.map(&:identity).include? r.identity } } ```

We’ll need to parallelise CI more so trying to split test cleanup once more

houndci-bot · 2018-07-15T04:40:57Z

test/integration/factories/collection_factory.rb

+    if DEBUG
+      p "Cleanup invoked in #{self} for example: #{@example}"
+      p "Resources to be deleted: #{resources.map { |r| r.name }}"
+      p "All subject resources: #{@subject.all.map { |s| s.name }}"


Style/SymbolProc: Pass &:name as an argument to map instead of a block.

houndci-bot · 2018-07-15T04:40:57Z

test/integration/factories/collection_factory.rb

+    resources = @subject.all.select { |resource| resource.name.match? /#{PREFIX}-[0-9]*-#{suit_name}/ }
+    if DEBUG
+      p "Cleanup invoked in #{self} for example: #{@example}"
+      p "Resources to be deleted: #{resources.map { |r| r.name }}"


Style/SymbolProc: Pass &:name as an argument to map instead of a block.

houndci-bot · 2018-07-15T04:40:57Z

test/integration/factories/collection_factory.rb

  def cleanup(async = false)
-    resources = @subject.all.select { |resource| resource.name.start_with? PREFIX }
+    suit_name = @example.gsub(/\W/, "").tr("_", "-").downcase.split('-')[0]
+    resources = @subject.all.select { |resource| resource.name.match? /#{PREFIX}-[0-9]*-#{suit_name}/ }


Lint/AmbiguousRegexpLiteral: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the / if it should be a division.

houndci-bot · 2018-07-15T04:40:57Z

test/integration/factories/collection_factory.rb

  def cleanup(async = false)
-    resources = @subject.all.select { |resource| resource.name.start_with? PREFIX }
+    suit_name = @example.gsub(/\W/, "").tr("_", "-").downcase.split('-')[0]


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-07-15T04:40:57Z

test/helpers/integration_test_helper.rb

@@ -5,6 +5,9 @@
 # XXX not sure if this will work on Travis CI or not
 Fog.credential = :test

+# Enable test debugging, providing additional information in some methods
+DEBUG = ENV['DEBUG'] || false


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-07-15T04:40:58Z

test/integration/factories/collection_factory.rb

+    if DEBUG
+      p "Cleanup invoked in #{self} for example: #{@example}"
+      p "Resources to be deleted: #{resources.map { |r| r.name }}"
+      p "All subject resources: #{@subject.all.map { |s| s.name }}"


Style/SymbolProc: Pass &:name as an argument to map instead of a block.

houndci-bot · 2018-07-15T04:40:58Z

test/integration/factories/collection_factory.rb

+    resources = @subject.all.select { |resource| resource.name.match? /#{PREFIX}-[0-9]*-#{suit_name}/ }
+    if DEBUG
+      p "Cleanup invoked in #{self} for example: #{@example}"
+      p "Resources to be deleted: #{resources.map { |r| r.name }}"


Style/SymbolProc: Pass &:name as an argument to map instead of a block.

houndci-bot · 2018-07-15T04:40:58Z

test/integration/factories/collection_factory.rb

  def cleanup(async = false)
-    resources = @subject.all.select { |resource| resource.name.start_with? PREFIX }
+    suit_name = @example.gsub(/\W/, "").tr("_", "-").downcase.split('-')[0]
+    resources = @subject.all.select { |resource| resource.name.match? /#{PREFIX}-[0-9]*-#{suit_name}/ }


Lint/AmbiguousRegexpLiteral: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the / if it should be a division.

houndci-bot · 2018-07-15T04:40:58Z

test/integration/factories/collection_factory.rb

  def cleanup(async = false)
-    resources = @subject.all.select { |resource| resource.name.start_with? PREFIX }
+    suit_name = @example.gsub(/\W/, "").tr("_", "-").downcase.split('-')[0]


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

houndci-bot · 2018-07-15T04:40:58Z

test/helpers/integration_test_helper.rb

@@ -5,6 +5,9 @@
 # XXX not sure if this will work on Travis CI or not
 Fog.credential = :test

+# Enable test debugging, providing additional information in some methods
+DEBUG = ENV['DEBUG'] || false


Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

Temikus · 2018-07-15T07:16:07Z

Alright, merging this. I'll need to parallelise things though. It now takes literally 2 hours.

Temikus added 5 commits July 14, 2018 13:39

Add source_image param to default disk factory

4aaa5a6

Add more docs to Server methods

b7e904b

Add private_ip_address method

7ef68e0

Add Server.stopped? method

180115b

Increase Server model test coverage

b0126f1

Temikus changed the title ~~Compute improv coverage~~ Improve Compute coverage Jul 14, 2018

Temikus added the integrate label Jul 14, 2018

houndci-bot reviewed Jul 15, 2018

View reviewed changes

Temikus force-pushed the compute_improv_coverage branch from 4f0be9f to d1c537f Compare July 15, 2018 01:57

Update CHANGELOG

8ca0339

Temikus force-pushed the compute_improv_coverage branch from d1c537f to 8ca0339 Compare July 15, 2018 02:03

Temikus added 5 commits July 15, 2018 13:29

Wait for DONE instead of “not pending”

9c266ac

This should be mostly a no-op, just a logical improvement. Waiting for !PENDING may cause some issues when operation is in a transitional state or they add another status to an operation on the backend.

Add some debugging to tests

4446028

Add a custom formatter for integration tests

baf9436

This will make it easier to spot long-running tests and get results from CI quicker.

Switch destroy to be asynchronous

a34a105

In theory this isn’t even needed as the bottom routine actually waits for resources to disappear from the listing: ``` resources.each { |r| Fog.wait_for { !@subject.all.map(&:identity).include? r.identity } } ```

Another attempt at per-suite resource cleanup

49e41ef

We’ll need to parallelise CI more so trying to split test cleanup once more

houndci-bot reviewed Jul 15, 2018

View reviewed changes

Temikus added 2 commits July 15, 2018 15:57

TIL ENV[“DEBUG”] enables debugging in google lib

2aa64d0

No resource.match? In Ruby 2.3

eb3e6e6

Temikus force-pushed the compute_improv_coverage branch from cbff6d2 to eb3e6e6 Compare July 15, 2018 06:38

Update CHANGELOG

ecfdfd2

Temikus merged commit d1d8058 into fog:master Jul 15, 2018

Temikus deleted the compute_improv_coverage branch March 20, 2019 02:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve Compute coverage #394

Improve Compute coverage #394

Temikus commented Jul 14, 2018

Temikus commented Jul 14, 2018

codecov bot commented Jul 15, 2018 •

edited

Loading

houndci-bot Jul 15, 2018

houndci-bot Jul 15, 2018

houndci-bot Jul 15, 2018

houndci-bot Jul 15, 2018

houndci-bot Jul 15, 2018

houndci-bot Jul 15, 2018

houndci-bot Jul 15, 2018

houndci-bot Jul 15, 2018

houndci-bot Jul 15, 2018

houndci-bot Jul 15, 2018

houndci-bot Jul 15, 2018

houndci-bot Jul 15, 2018

Temikus commented Jul 15, 2018

Improve Compute coverage #394

Improve Compute coverage #394

Conversation

Temikus commented Jul 14, 2018

Temikus commented Jul 14, 2018

codecov bot commented Jul 15, 2018 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Temikus commented Jul 15, 2018

codecov bot commented Jul 15, 2018 •

edited

Loading