Only set exec_properties on the underlying rule (#134)

Fixes #133
fmeum · Dec 3, 2024 · 79fb112 · 79fb112
1 parent 50fb3c4
commit 79fb112
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/examples/cc_define_test/BUILD.bazel b/examples/cc_define_test/BUILD.bazel
@@ -23,6 +23,10 @@ cc_define_test(
             "GREETING_RLOCATIONPATH": "$(rlocationpath :greeting_generic.txt)",
         },
     }),
+    exec_properties = {
+        # Exec groups of the underlying rule can be referenced.
+        "test.hello": "world",
+    },
     deps = ["@bazel_tools//tools/cpp/runfiles"],
 )
 

diff --git a/with_cfg/private/wrapper.bzl b/with_cfg/private/wrapper.bzl
@@ -29,12 +29,13 @@ def make_wrapper(
 # Attributes common to all rules.
 # These attributes are applied to all targets generated by the wrapper.
 # testonly, tags and visibility are handled specially.
+# exec_properties are only relevant for the underlying rule's actions
+# and may reference exec groups only defined on that rule.
 _COMMON_ATTRS = [
     # keep sorted
     "compatible_with",
     "deprecation",
     "exec_compatible_with",
-    "exec_properties",
     "features",
     "restricted_to",
     "target_compatible_with",