Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update uv and remove pip workaround in default image builder #2674

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

thomasjpfan
Copy link
Member

Why are the changes needed?

With astral-sh/uv#5944 the latest version of uv now works with git & subdirectories.

What changes were proposed in this pull request?

This PR removed the work around with using pip.

How was this patch tested?

I ran this image spec:

from flytekit import ImageSpec, task, workflow

interactive = "git+https://github.com/flyteorg/flytekit.git@master#subdirectory=plugins/flytekit-flyteinteractive"

image = ImageSpec(
    name="interactive",
    builder="default",
    apt_packages=["git"],
    packages=["numpy==1.26.4", interactive],
    registry="localhost:30000",
)


@task(container_image=image)
def fn() -> int:
    import numpy as np

    x = np.array([1, 2, 3])

    return int(x.sum())


@workflow
def main() -> int:
    return fn()

Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
@thomasjpfan thomasjpfan changed the title Update uv and remove pip workaround Update uv and remove pip workaround in default image builder Aug 10, 2024
Copy link

codecov bot commented Aug 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.13%. Comparing base (69445ff) to head (e6f6e78).

Files Patch % Lines
flytekit/image_spec/default_builder.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2674       +/-   ##
===========================================
- Coverage   79.24%   43.13%   -36.11%     
===========================================
  Files         196      220       +24     
  Lines       19785    20837     +1052     
  Branches     4008     4005        -3     
===========================================
- Hits        15678     8989     -6689     
- Misses       3407    11620     +8213     
+ Partials      700      228      -472     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomasjpfan thomasjpfan merged commit 768ae81 into flyteorg:master Aug 10, 2024
99 of 101 checks passed
Mecoli1219 pushed a commit to Mecoli1219/flytekit that referenced this pull request Aug 14, 2024
…g#2674)

Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Mecoli1219 pushed a commit to Mecoli1219/flytekit that referenced this pull request Aug 14, 2024
…g#2674)

Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Mecoli1219 <michaellai901026@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants