Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doc): Define the core-crm package correctly in Transitive Dependency Resolution concept page #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −5
Open

fix(doc): Define the core-crm package correctly in Transitive Dependency Resolution concept page #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a548e2e
fix(doc): Define the core-crm package correctly in Transitive Depende…
ruslan-kurchenko Apr 17, 2024
2187ec5
fix(doc): Small fix to replace plugins.sfpowerscripts with plugins.sf…
ruslan-kurchenko Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ng-aspects-of-the-build-command/use-of-multiple-config-file-in-build-command.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ For example, if you have two packages, package 1 is dependent on `SharedActiviti
}
],
"plugins": {
"sfpowerscripts":{
"sfp":{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruslan-kurchenko let me check the code, I think its still sfpowerscripts for this one, for backward compatibility

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was failing for us with sfpowerscripts

"<a data-footnote-ref href="#user-content-fn-1">scratchOrgDefFilePaths</a>":{
"enableMultiDefinitionFiles": true,
"packages": {
Expand Down
18 changes: 14 additions & 4 deletions concepts/transitive-dependency-resolution.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ This feature is by default activated whenever build/quickbuild even in implicit

Let's consider the following sfdx-project.json to explain how this feature works.

```
```json
{
"packageDirectories": [
{
Expand All @@ -20,13 +20,23 @@ Let's consider the following sfdx-project.json to explain how this feature works
"versionNumber": "1.0.6.NEXT",
"dependencies": [
{
"package": "sfdc-logging".
"package": "sfdc-logging",
"versionNumber": "1.0.2.LATEST"
}
]
},
c

{
"path": "./src/core-crm",
"package": "core-crm",
"versionName": "Version 1.0.4",
"versionNumber": "1.0.4.NEXT",
"dependencies": [
{
"package": "feature-mgmt",
"versionNumber": "1.0.6.LATEST"
}
]
}
],
"namespace": "",
"sfdcLoginUrl": "https://login.salesforce.com",
Expand Down